212603 – x86.rb's LabelReference.x86LoadOperand()'s address operand should be a pointer type.

Bug 212603 - x86.rb's LabelReference.x86LoadOperand()'s address operand should be a pointer type.

Summary: x86.rb's LabelReference.x86LoadOperand()'s address operand should be a pointe...

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	JavaScriptCore (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Mark Lam

URL:
Keywords:	InRadar

Depends on:
Blocks:

Attachments
proposed patch. (1.69 KB, patch) 2020-06-01 12:23 PDT, Mark Lam	saam: review+	Details \| Formatted Diff \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Mark Lam 2020-06-01 12:19:13 PDT

The current implementation mistakenly sets the address type to that of the value being loaded.

Comment 1 Mark Lam 2020-06-01 12:23:04 PDT

Created attachment 400746 [details]
proposed patch.

Comment 2 Yusuke Suzuki 2020-06-01 12:35:17 PDT

Comment on attachment 400746 [details]
proposed patch.

r=me too

Comment 3 Mark Lam 2020-06-01 12:36:35 PDT

Thanks for the review.  Landed in r262389: <http://trac.webkit.org/r262389>.

Comment 4 Radar WebKit Bug Importer 2020-06-01 12:37:18 PDT

<rdar://problem/63839299>