Bug 212583 - REGRESSION[r260844]: [GTK][WPE] Inspector GResource no longer updated after WebInspectorUI file updates
Summary: REGRESSION[r260844]: [GTK][WPE] Inspector GResource no longer updated after W...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 210942
Blocks:
  Show dependency tree / graph
 
Reported: 2020-05-31 10:17 PDT by Philippe Normand
Modified: 2020-06-02 17:58 PDT (History)
15 users (show)

See Also:

Attachments
patch (1.49 KB, patch)
2020-06-02 16:10 PDT, Christopher Reid 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2020-05-31 10:17:39 PDT 
+++ This bug was initially created as a clone of Bug #210942 +++

Reproducer:

1. Full clean GTK build from scratch
2. Edit GraphicsTabContentView.js, change the tabIcon to Gear.svg
3. Update your build
4. Start Minibrowser, open WebInspector

Expected result: The graphics tab uses the gear icon
Current result: The graphics tab uses the graphics icon

Workaround: to force an update of the GResource: find WebKitBuild/ -name InspectorGResourceBundle.xml -exec rm {} \; and then rebuild...

I've tried to revert r260844, doesn't change anything...
Comment 1 Christopher Reid 2020-06-02 16:10:18 PDT 
Created attachment 400865 [details]
patch

This seems to fix the problem, the dependency on the WebInspectorUI target wasn't enough to trigger rebuilds.
I've also tried clean GTK builds to make sure this works.
Comment 2 EWS 2020-06-02 17:58:00 PDT 
Committed r262466: <https://trac.webkit.org/changeset/262466>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400865 [details].