WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
212572
Add ENABLE(TOUCH_ACTION_REGIONS) to wrap code that's only relevant for platforms that consult touch-action for event handling
https://bugs.webkit.org/show_bug.cgi?id=212572
Summary
Add ENABLE(TOUCH_ACTION_REGIONS) to wrap code that's only relevant for platfo...
Simon Fraser (smfr)
Reported
2020-05-30 12:36:50 PDT
Add ENABLE(TOUCH_ACTION_REGIONS) to wrap code that's only relevant for platforms that consult touch-action for event handling
Attachments
Patch
(14.70 KB, patch)
2020-05-30 12:37 PDT
,
Simon Fraser (smfr)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2020-05-30 12:37:33 PDT
Created
attachment 400675
[details]
Patch
Andy Estes
Comment 2
2020-05-30 12:41:13 PDT
Comment on
attachment 400675
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=400675&action=review
> Source/WTF/wtf/PlatformEnable.h:491 > +#if !defined(ENABLE_TOUCH_ACTION_REGIONS) > +#define ENABLE_TOUCH_ACTION_REGIONS 0 > +#endif
Not sure why we have to do this when the default is 0, because !ENABLE_TOUCH_ACTION_REGIONS and !defined(ENABLE_TOUCH_ACTION_REGIONS) is the same as far as the ENABLE() macro is concerned.
EWS
Comment 3
2020-06-01 12:38:40 PDT
Committed
r262390
: <
https://trac.webkit.org/changeset/262390
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 400675
[details]
.
Radar WebKit Bug Importer
Comment 4
2020-06-01 12:39:16 PDT
<
rdar://problem/63839368
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug