Bug 212544 - [iOS] Unable to paste images when composing mail at yahoo.com
Summary: [iOS] Unable to paste images when composing mail at yahoo.com
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-29 14:01 PDT by Wenson Hsieh
Modified: 2020-05-29 16:09 PDT (History)
8 users (show)

See Also:

Attachments
Patch (3.75 KB, patch)
2020-05-29 14:14 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Take 2 (4.48 KB, patch)
2020-05-29 15:22 PDT, Wenson Hsieh 		megan_gardner: review+
aestes: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2020-05-29 14:01:57 PDT 
<rdar://problem/63511613>
Comment 1 Wenson Hsieh 2020-05-29 14:14:14 PDT Comment hidden (obsolete)
Comment 2 Tim Horton 2020-05-29 14:32:07 PDT 
Comment on attachment 400614 [details]
Patch

Way insufficient coverage of Yahoo TLDs
Comment 3 Wenson Hsieh 2020-05-29 15:22:34 PDT 
Created attachment 400625 [details]
Take 2
Comment 4 Andy Estes 2020-05-29 16:02:53 PDT 
Comment on attachment 400625 [details]
Take 2

View in context: https://bugs.webkit.org/attachment.cgi?id=400625&action=review

> Source/WebCore/page/Quirks.cpp:826
> +        m_shouldAvoidPastingImagesAsWebContent = host.startsWith("mail.") && topPrivatelyControlledDomain(host).startsWith("yahoo.");

Since this is a hostname, do you need to use startsWithIgnoringASCIICase instead? Or does URL do some sort of lowercase canonicalization?
Comment 5 Andy Estes 2020-05-29 16:03:45 PDT 
Comment on attachment 400625 [details]
Take 2

Feel free to cq+ again if startsWithIgnoringASCIICase isn't needed.
Comment 6 Wenson Hsieh 2020-05-29 16:05:25 PDT 
(In reply to Andy Estes from comment #5)
> Comment on attachment 400625 [details]
> Take 2
> 
> Feel free to cq+ again if startsWithIgnoringASCIICase isn't needed.

Good catch — I think the host name check should use startsWithIgnoringASCIICase.
Comment 7 Wenson Hsieh 2020-05-29 16:09:53 PDT 
Committed r262323: <https://trac.webkit.org/changeset/262323>