RESOLVED FIXED 212540
[EME] navigator.requestMediaKeySystemAccess() should reject PUR sessionTypes in private browsing mode. 
https://bugs.webkit.org/show_bug.cgi?id=212540
Summary [EME] navigator.requestMediaKeySystemAccess() should reject PUR sessionTypes ...
Jer Noble
Reported 2020-05-29 13:44:14 PDT
[EME] navigator.requestMediaKeySystemAccess() should reject PUR sessionTypes in private browsing mode.
Attachments
Patch (4.97 KB, patch)
2020-05-29 13:47 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (4.95 KB, patch)
2020-05-29 13:48 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2020-05-29 13:45:00 PDT
<rdar://problem/61125757>
Jer Noble
Comment 2 2020-05-29 13:47:51 PDT
Created attachment 400608 [details] Patch
Jer Noble
Comment 3 2020-05-29 13:48:41 PDT
Created attachment 400609 [details] Patch
Peng Liu
Comment 4 2020-05-29 14:09:54 PDT
Comment on attachment 400609 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400609&action=review > LayoutTests/platform/mac/media/encrypted-media/fps-ephemeral-requestMediaKeySystemAccess.html:19 > + consoleWrite('This test must be run in private browsing mode.') This log message is not so clear. The browser will be in private browsing mode if window.internals is not empty? Also, do we need to exit the test if the browser is not in the private browsing mode?
Jer Noble
Comment 5 2020-05-29 14:14:04 PDT
(In reply to Peng Liu from comment #4) > Comment on attachment 400609 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=400609&action=review > > > LayoutTests/platform/mac/media/encrypted-media/fps-ephemeral-requestMediaKeySystemAccess.html:19 > > + consoleWrite('This test must be run in private browsing mode.') > > This log message is not so clear. The browser will be in private browsing > mode if window.internals is not empty? Also, do we need to exit the test if > the browser is not in the private browsing mode? This line will only be printed I window.internals is empty, or in other words, if someone loads this test directly in a web browser. The test will fail unless the page is loaded in private browsing mode.
Jer Noble
Comment 6 2020-05-29 16:08:50 PDT
Test failures are due to r262311, fixed in r262318. Landing.
EWS
Comment 7 2020-05-29 16:16:19 PDT
Committed r262324: <https://trac.webkit.org/changeset/262324> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400609 [details].
Note You need to log in before you can comment on or make changes to this bug.