Bug 212538 - We need to properly model heap ranges of Delete in DFG/B3
Summary: We need to properly model heap ranges of Delete in DFG/B3
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-29 12:01 PDT by Saam Barati
Modified: 2020-05-29 21:39 PDT (History)
14 users (show)

See Also:

Attachments
patch (13.02 KB, patch)
2020-05-29 12:59 PDT, Saam Barati 		fpizlo: review+
Details | Formatted Diff | Diff
patch for landing (12.81 KB, patch)
2020-05-29 15:01 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2020-05-29 12:01:58 PDT 
...
Comment 1 Saam Barati 2020-05-29 12:02:27 PDT 
<rdar://problem/63670964>
Comment 2 Saam Barati 2020-05-29 12:59:15 PDT 
Created attachment 400607 [details]
patch
Comment 3 Filip Pizlo 2020-05-29 14:29:29 PDT 
Comment on attachment 400607 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400607&action=review

R=me with comment.

> Source/JavaScriptCore/ftl/FTLAbstractHeapRepository.h:159
> +    macro(JSCell_header_and_named_properties, 0) \

This should be an abstract heap, not an abstract field, since the offset is not meaningful.
Comment 4 Saam Barati 2020-05-29 14:36:02 PDT 
Comment on attachment 400607 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400607&action=review

>> Source/JavaScriptCore/ftl/FTLAbstractHeapRepository.h:159
>> +    macro(JSCell_header_and_named_properties, 0) \
> 
> This should be an abstract heap, not an abstract field, since the offset is not meaningful.

Thanks. Will fix.
Comment 5 Saam Barati 2020-05-29 15:01:20 PDT 
Created attachment 400624 [details]
patch for landing
Comment 6 EWS 2020-05-29 21:39:40 PDT 
Committed r262338: <https://trac.webkit.org/changeset/262338>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400624 [details].