Bug 212523 - Add some logging to ServiceWorkerThread to track install/activate event handling
Summary: Add some logging to ServiceWorkerThread to track install/activate event handling
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-29 07:39 PDT by youenn fablet
Modified: 2020-06-02 06:44 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.48 KB, patch)
2020-05-29 07:44 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (3.71 KB, patch)
2020-06-02 04:53 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-05-29 07:39:56 PDT 
Add some logging to ServiceWorkerThread to track install/active event handling
Comment 1 youenn fablet 2020-05-29 07:44:49 PDT 
Created attachment 400578 [details]
Patch
Comment 2 Chris Dumez 2020-05-29 08:25:18 PDT 
Comment on attachment 400578 [details]
Patch

I find that this kind of logging is usually more useful if it also logs some way to identify the service worker (like an id).
Comment 3 youenn fablet 2020-06-02 04:53:06 PDT 
Created attachment 400804 [details]
Patch for landing
Comment 4 EWS 2020-06-02 06:39:54 PDT 
Committed r262416: <https://trac.webkit.org/changeset/262416>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400804 [details].
Comment 5 Radar WebKit Bug Importer 2020-06-02 06:40:18 PDT 
<rdar://problem/63872704>
Comment 6 youenn fablet 2020-06-02 06:44:46 PDT 
(In reply to Chris Dumez from comment #2)
> Comment on attachment 400578 [details]
> Patch
> 
> I find that this kind of logging is usually more useful if it also logs some
> way to identify the service worker (like an id).

I added some IDs, that will indeed ease debugging.