Bug 212516 - [WebXR] WebXRSystem::unregisterSimulatedXRDeviceForTesting() ASSERTs in m_immersiveDevices.contains(device)
Summary: [WebXR] WebXRSystem::unregisterSimulatedXRDeviceForTesting() ASSERTs in m_imm...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords: InRadar
Depends on:
Blocks: 212513
  Show dependency treegraph
 
Reported: 2020-05-29 03:00 PDT by Sergio Villar Senin
Modified: 2020-05-29 06:19 PDT (History)
5 users (show)

See Also:


Attachments
Patch (3.76 KB, patch)
2020-05-29 03:04 PDT, Sergio Villar Senin
zan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2020-05-29 03:00:31 PDT
[WebXR] WebXRSystem::unregisterSimulatedXRDeviceForTesting() ASSERTs in m_immersiveDevices.contains(device)
Comment 1 Sergio Villar Senin 2020-05-29 03:04:58 PDT
Created attachment 400562 [details]
Patch
Comment 2 Zan Dobersek 2020-05-29 03:24:10 PDT
Comment on attachment 400562 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400562&action=review

> Source/WebCore/Modules/webxr/WebXRSystem.cpp:457
> +    UNUSED_VARIABLE(removed);
> +    ASSERT(removed || m_inlineXRDevice == &device);

Can be folded into ASSERT_UNUSED.
Comment 3 Sergio Villar Senin 2020-05-29 06:18:13 PDT
Committed r262291: <https://trac.webkit.org/changeset/262291>
Comment 4 Radar WebKit Bug Importer 2020-05-29 06:19:17 PDT
<rdar://problem/63757315>