NEW 212515
Adjust <link rel=stylesheet disabled> handling 
https://bugs.webkit.org/show_bug.cgi?id=212515
Summary Adjust <link rel=stylesheet disabled> handling
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-07-01 11:20:38 PDT
<rdar://problem/96304439>
Brent Fulgham
Comment 2 2022-07-01 11:20:49 PDT
It looks like we fail a couple of these tests (though we pass most). Importing.
Ahmad Saleem
Comment 3 2023-06-08 06:31:26 PDT
We are only browser failing but just two tests: https://wpt.fyi/results/css/cssom?label=master&label=experimental&aligned=&q=cssom%2Fhtmllinkelement-
Ahmad Saleem
Comment 4 2023-08-23 13:47:04 PDT
Blink Commit - https://chromium-review.googlesource.com/c/chromium/src/+/2216701
sideshowbarker
Comment 5 2023-08-23 19:09:29 PDT
(In reply to Ahmad Saleem from comment #3) > We are only browser failing but just two tests: > > https://wpt.fyi/results/css/ > cssom?label=master&label=experimental&aligned=&q=cssom%2Fhtmllinkelement- The patch in https://github.com/WebKit/WebKit/pull/17001 gets WebKit passing all those tests. But that patch isn’t a full implementation of the spec requirements in https://github.com/whatwg/html/pull/4519. I have a separate patch that implements the “explicitly enabled” boolean flag specified in https://github.com/whatwg/html/pull/4519 — but I don’t yet know how to test it, or if WebKit even needs it. I say that because HTMLLinkElement-disabled-003.html to HTMLLinkElement-disabled-007.html there all include some tests for the “explicitly enabled” requirements — but since WebKit is already passing all those tests, then it seems like either those tests aren’t correctly testing the “explicitly enabled” requirements, or else the WebKit implementation somehow already conforms to those requirements.
Emilio Cobos Álvarez (:emilio)
Comment 6 2023-08-23 20:34:16 PDT
The "explicitly enabled" boolean flag is implemented as m_disabledState == EnabledViaScript in WebKit.
sideshowbarker
Comment 7 2023-08-23 21:01:01 PDT
(In reply to Emilio Cobos Álvarez (:emilio) from comment #6) > The "explicitly enabled" boolean flag is implemented as m_disabledState == > EnabledViaScript in WebKit. aha, I see now — thanks much
Tim Nguyen (:ntim)
Comment 8 2023-08-23 21:44:13 PDT
Should this be duped to bug 260642?
Note You need to log in before you can comment on or make changes to this bug.