Bug 212508 - Avoid unnecessary sync IPC messages when togging the callout bar for selections
Summary: Avoid unnecessary sync IPC messages when togging the callout bar for selections
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-28 19:22 PDT by Megan Gardner
Modified: 2020-05-28 22:42 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.29 KB, patch)
2020-05-28 19:26 PDT, Megan Gardner 		no flags Details | Formatted Diff | Diff
Patch for landing (3.23 KB, patch)
2020-05-28 22:07 PDT, Megan Gardner 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2020-05-28 19:22:20 PDT 
Avoid unnessecary sync IPC messages when togging the callout bar for selections.
Comment 1 Megan Gardner 2020-05-28 19:26:29 PDT 
Created attachment 400537 [details]
Patch
Comment 2 Wenson Hsieh 2020-05-28 19:29:19 PDT 
Comment on attachment 400537 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400537&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2566
> +                if (!_page->editorState().selectionIsRange)
> +                    return NO;
> +                if ([self _pointIsInsideSelectionRect:point outBoundingRect:nil])
> +                    return YES;
> +                return NO;

Nit - I would just write this `return [self _pointIsInsideSelectionRect:point outBoundingRect:nil];`.
Comment 3 Wenson Hsieh 2020-05-28 19:30:53 PDT 
Comment on attachment 400537 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400537&action=review

> Source/WebKit/ChangeLog:3
> +        Avoid unnessecary sync IPC messages when togging the callout bar for selections.

Nit - unnecessary
Comment 4 Megan Gardner 2020-05-28 22:07:16 PDT 
Created attachment 400547 [details]
Patch for landing
Comment 5 EWS 2020-05-28 22:41:06 PDT 
Committed r262280: <https://trac.webkit.org/changeset/262280>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400547 [details].
Comment 6 Radar WebKit Bug Importer 2020-05-28 22:42:14 PDT 
<rdar://problem/63747401>