Bug 212473 - Implement named item condition for images
Summary: Implement named item condition for images
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-28 09:53 PDT by Rob Buis
Modified: 2020-05-31 03:41 PDT (History)
6 users (show)

See Also:


Attachments
Patch (5.31 KB, patch)
2020-05-28 09:57 PDT, Rob Buis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2020-05-28 09:53:26 PDT
Implement named item condition for images, not only should we check there are both an id and a
name attribute, but also that the name attribute is non-empty:
https://html.spec.whatwg.org/multipage/dom.html#dom-document-nameditem-filter
Comment 1 Rob Buis 2020-05-28 09:57:56 PDT
Created attachment 400473 [details]
Patch
Comment 2 Maciej Stachowiak 2020-05-31 03:12:35 PDT
Comment on attachment 400473 [details]
Patch

r=me
Comment 3 EWS 2020-05-31 03:40:17 PDT
Committed r262360: <https://trac.webkit.org/changeset/262360>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400473 [details].
Comment 4 Radar WebKit Bug Importer 2020-05-31 03:41:22 PDT
<rdar://problem/63805627>