Bug 212468 - Web Inspector: generate_cpp_protocol_types_header.py:294: SyntaxWarning: "is" with a literal. Did you mean "=="?
Summary: Web Inspector: generate_cpp_protocol_types_header.py:294: SyntaxWarning: "is"...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-28 07:51 PDT by Michael Catanzaro
Modified: 2020-05-28 08:32 PDT (History)
12 users (show)

See Also:


Attachments
Patch (1.70 KB, patch)
2020-05-28 07:52 PDT, Michael Catanzaro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2020-05-28 07:51:21 PDT
I just noticed this build warning with python 3.8.3, not sure if it's new or if I've just never noticed before:

[155/1729] Generating ../../DerivedSou...spector/InspectorBackendCommands.js.in
/home/mcatanzaro/Projects/WebKit/Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_header.py:294: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if line.startswith(('#', '/*', '*/', '//')) or len(line) is 0:

Fix is trivial.
Comment 1 Michael Catanzaro 2020-05-28 07:52:12 PDT
Created attachment 400457 [details]
Patch
Comment 2 EWS Watchlist 2020-05-28 07:53:16 PDT
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Comment 3 EWS 2020-05-28 08:31:09 PDT
Committed r262243: <https://trac.webkit.org/changeset/262243>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400457 [details].
Comment 4 Radar WebKit Bug Importer 2020-05-28 08:32:24 PDT
<rdar://problem/63719116>