Bug 212464 - Allow using web processes for service workers even though they loaded about URLs
Summary: Allow using web processes for service workers even though they loaded about URLs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-28 06:04 PDT by youenn fablet
Modified: 2020-06-03 10:33 PDT (History)
5 users (show)

See Also:

Attachments
Patch (5.17 KB, patch)
2020-05-28 06:09 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (5.17 KB, patch)
2020-06-02 08:44 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-05-28 06:04:41 PDT 
Allow using web processes for service workers even though they loaded about URLs
Comment 1 youenn fablet 2020-05-28 06:09:40 PDT 
Created attachment 400448 [details]
Patch
Comment 2 youenn fablet 2020-05-28 07:29:00 PDT 
Test failures are related to a runtime flag change, this will be fixed at https://bugs.webkit.org/show_bug.cgi?id=212466.
Comment 3 youenn fablet 2020-06-02 04:27:14 PDT 
Comment on attachment 400448 [details]
Patch

This changes also the WebProcessCache, which might be an improvement as well.
The case that might need to be dealt with in the future is the case of a tab opening about:blank in another process and then writing data on it.
The new process should then have its registrable domain set to the tab opener and I am not sure this is guaranteed now.
Comment 4 Chris Dumez 2020-06-02 08:29:45 PDT 
Comment on attachment 400448 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400448&action=review

> Source/WebKit/ChangeLog:9
> +        A web process that is running service workers and is laoding an about:blank page will also kill its service workers.

typo: laoding
Comment 5 youenn fablet 2020-06-02 08:44:19 PDT 
Created attachment 400829 [details]
Patch for landing
Comment 6 EWS 2020-06-02 11:38:30 PDT 
Committed r262432: <https://trac.webkit.org/changeset/262432>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400829 [details].
Comment 7 Radar WebKit Bug Importer 2020-06-02 11:39:16 PDT 
<rdar://problem/63884712>
Comment 8 Jason Lawrence 2020-06-03 09:02:52 PDT 
The commit above appears to have caused a regression here: https://bugs.webkit.org/show_bug.cgi?id=212696
Comment 9 Jonathan Bedard 2020-06-03 10:32:28 PDT 
Committed r262493: <https://trac.webkit.org/changeset/262493>
Comment 10 Jonathan Bedard 2020-06-03 10:33:26 PDT 
(In reply to Jonathan Bedard from comment #9)
> Committed r262493: <https://trac.webkit.org/changeset/262493>

This is a build-fix for Debug Catalyst builds.