Bug 212464 – Allow using web processes for service workers even though they loaded about URLs

• Status: RESOLVED
• Resolution: FIXED
• Component: Service Workers

[youenn fablet]

Allow using web processes for service workers even though they loaded about URLs

[youenn fablet]

Created attachment 400448 [details]
Patch

[youenn fablet]

Test failures are related to a runtime flag change, this will be fixed at https://bugs.webkit.org/show_bug.cgi?id=212466.

[youenn fablet]

Comment on attachment 400448 [details]
Patch

This changes also the WebProcessCache, which might be an improvement as well.
The case that might need to be dealt with in the future is the case of a tab opening about:blank in another process and then writing data on it.
The new process should then have its registrable domain set to the tab opener and I am not sure this is guaranteed now.

[Chris Dumez]

Comment on attachment 400448 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400448&action=review

> Source/WebKit/ChangeLog:9
> +        A web process that is running service workers and is laoding an about:blank page will also kill its service workers.

typo: laoding

[youenn fablet]

Created attachment 400829 [details]
Patch for landing

[EWS]

Committed r262432: <https://trac.webkit.org/changeset/262432>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400829 [details].

[Radar WebKit Bug Importer]

<rdar://problem/63884712>

[Jason Lawrence]

The commit above appears to have caused a regression here: https://bugs.webkit.org/show_bug.cgi?id=212696

[Jonathan Bedard]

Committed r262493: <https://trac.webkit.org/changeset/262493>

[Jonathan Bedard]

(In reply to Jonathan Bedard from comment #9)
> Committed r262493: <https://trac.webkit.org/changeset/262493>

This is a build-fix for Debug Catalyst builds.