Bug 212463 - Add .editorconfig
Summary: Add .editorconfig
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yoshiaki Jitsukawa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-28 05:28 PDT by Yoshiaki Jitsukawa
Modified: 2020-06-04 11:02 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.46 KB, patch)
2020-05-28 05:37 PDT, Yoshiaki Jitsukawa
no flags Details | Formatted Diff | Diff
Patch (1.42 KB, patch)
2020-05-28 13:05 PDT, Yoshiaki Jitsukawa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yoshiaki Jitsukawa 2020-05-28 05:28:04 PDT
Add .editorconfig mainly for Visual Studio.
Comment 1 Yoshiaki Jitsukawa 2020-05-28 05:37:26 PDT
Created attachment 400446 [details]
Patch
Comment 2 Yoshiaki Jitsukawa 2020-05-28 13:05:27 PDT
Created attachment 400498 [details]
Patch
Comment 3 Yoshiaki Jitsukawa 2020-05-28 13:07:06 PDT
Removed "root" in order to honor parent .editorconfig user may be using.
Comment 4 Yoshiaki Jitsukawa 2020-06-02 00:42:36 PDT
Thanks for the review!
Comment 5 EWS 2020-06-02 00:44:52 PDT
Committed r262408: <https://trac.webkit.org/changeset/262408>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400498 [details].
Comment 6 Radar WebKit Bug Importer 2020-06-02 00:45:18 PDT
<rdar://problem/63863651>
Comment 7 Mark Lam 2020-06-04 07:05:58 PDT
Comment on attachment 400498 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400498&action=review

> .editorconfig:8
> +trim_trailing_whitespace = true

Why this? As a result of this change, it's forcing my editor (bbedit) to trim trailing whitespaces in a file every time I save.  That makes for a lot of unrelated changes on every patch.  Is this really necessary?
Comment 8 Yusuke Suzuki 2020-06-04 09:57:30 PDT
(In reply to Mark Lam from comment #7)
> Comment on attachment 400498 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=400498&action=review
> 
> > .editorconfig:8
> > +trim_trailing_whitespace = true
> 
> Why this? As a result of this change, it's forcing my editor (bbedit) to
> trim trailing whitespaces in a file every time I save.  That makes for a lot
> of unrelated changes on every patch.  Is this really necessary?

Yeah, I think we should remove this line from .editorconfig.
I'm working around this issue by adding

let g:EditorConfig_disable_rules = ['trim_trailing_whitespace']

to my .vimrc :P