Bug 212463 – Add .editorconfig

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Yoshiaki Jitsukawa]

Add .editorconfig mainly for Visual Studio.

[Yoshiaki Jitsukawa]

Created attachment 400446 [details]
Patch

[Yoshiaki Jitsukawa]

Created attachment 400498 [details]
Patch

[Yoshiaki Jitsukawa]

Removed "root" in order to honor parent .editorconfig user may be using.

[Yoshiaki Jitsukawa]

Thanks for the review!

[EWS]

Committed r262408: <https://trac.webkit.org/changeset/262408>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400498 [details].

[Radar WebKit Bug Importer]

<rdar://problem/63863651>

[Mark Lam]

Comment on attachment 400498 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400498&action=review

> .editorconfig:8
> +trim_trailing_whitespace = true

Why this? As a result of this change, it's forcing my editor (bbedit) to trim trailing whitespaces in a file every time I save.  That makes for a lot of unrelated changes on every patch.  Is this really necessary?

[Yusuke Suzuki]

(In reply to Mark Lam from comment #7)
> Comment on attachment 400498 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=400498&action=review
> 
> > .editorconfig:8
> > +trim_trailing_whitespace = true
> 
> Why this? As a result of this change, it's forcing my editor (bbedit) to
> trim trailing whitespaces in a file every time I save.  That makes for a lot
> of unrelated changes on every patch.  Is this really necessary?

Yeah, I think we should remove this line from .editorconfig.
I'm working around this issue by adding

let g:EditorConfig_disable_rules = ['trim_trailing_whitespace']

to my .vimrc :P