Bug 212437 – Limit memory used by wasm/references/multitable.js on memory limited devices

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Saam Barati]

...

[Saam Barati]

Currently uses 600MB and jetsams iOS tests

[Saam Barati]

Created attachment 400400 [details]
patch

[Keith Miller]

Comment on attachment 400400 [details]
patch

r=me

[Mark Lam]

Comment on attachment 400400 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400400&action=review

> JSTests/wasm/references/multitable.js:428
> +          .End().WebAssembly().get())), Error, "Table count of 1000000 is too big, maximum 1000000");

Parameterize on largeNumber too instead of hardcoding 1000000 in the message?

> Source/JavaScriptCore/jsc.cpp:2497
> +EncodedJSValue JSC_HOST_CALL functionIsMemoryLimited(JSGlobalObject*, CallFrame*)
> +{
> +#if PLATFORM(IOS) || PLATFORM(TVOS) || PLATFORM(WATCHOS)
> +    return JSValue::encode(jsBoolean(true));
> +#else
> +    return JSValue::encode(jsBoolean(false));
> +#endif
> +}

Put this in $vm because it may be useful for LayoutTests too?

[Saam Barati]

Comment on attachment 400400 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400400&action=review

>> JSTests/wasm/references/multitable.js:428
>> +          .End().WebAssembly().get())), Error, "Table count of 1000000 is too big, maximum 1000000");
> 
> Parameterize on largeNumber too instead of hardcoding 1000000 in the message?

this one is needed since it's an actual test that 1000000 exceeds the limit

>> Source/JavaScriptCore/jsc.cpp:2497
>> +}
> 
> Put this in $vm because it may be useful for LayoutTests too?

Yeah I can do that

[Saam Barati]

Created attachment 400404 [details]
patch for landing

[Saam Barati]

Created attachment 400405 [details]
patch for landing

[EWS]

Committed r262227: <https://trac.webkit.org/changeset/262227>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400405 [details].

[Radar WebKit Bug Importer]

<rdar://problem/63698021>