RESOLVED INVALID 212435
makeprop.pl should use a preprocessor instead of "defines" 
https://bugs.webkit.org/show_bug.cgi?id=212435
Summary makeprop.pl should use a preprocessor instead of "defines"
Darin Adler
Reported 2020-05-27 14:58:45 PDT
The makeprop.pl script decides which properties to include based on conditions inside the JSON file. But instead it should use a preprocessor so it can share feature definitions with C++ and makevalues.pl.
Attachments
Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2020-05-27 14:59:59 PDT
Unfortunately that means that CSSProperties.json would not actually be a JSON file any more. It would be a JSON file with preprocessor defines in it. Maybe there's some better way?
Daniel Bates
Comment 2 2020-05-27 15:32:18 PDT
JSON is consumed by <https://webkit.org/css-status/>. Solution should include plan to keep that working.
Timothy Hatcher
Comment 3 2020-05-27 15:38:32 PDT
The JSON on that page is directly loaded from SVN: https://svn.webkit.org/repository/webkit/trunk/Source/WebCore/css/CSSProperties.json
Daniel Bates
Comment 4 2020-05-27 15:43:00 PDT
(In reply to Darin Adler from comment #1) > Unfortunately that means that CSSProperties.json would not actually be a > JSON file any more. It would be a JSON file with preprocessor defines in it. > Maybe there's some better way? To find an elegant solution I would need to think about it. Working with the constraints at hand: must use preprocessor and must keep webkit.org CSS page working then easy solution is to patch up webkit.org CSS page to remove preprocessor directives before parsing as JSON.
Darin Adler
Comment 5 2020-05-27 18:19:46 PDT
I found a way. I won’t change this script or file.
Note You need to log in before you can comment on or make changes to this bug.