RESOLVED FIXED 212408
[Flatpak][GStreamer] all commands, except webkit-build, fails if GST_BUILD_PATH is set 
https://bugs.webkit.org/show_bug.cgi?id=212408
Summary [Flatpak][GStreamer] all commands, except webkit-build, fails if GST_BUILD_PA...
Víctor M. Jáquez L.
Reported 2020-05-27 07:09:45 PDT
Even that bug 212343 solved the compilation, the rest of the operations in flatpak with GST_BUILD_PATH set remains failing. The regression were introduced in r262057 as far as I understand, where the flatpak's argument 'command' were added.
Attachments
Patch (3.03 KB, patch)
2020-05-27 07:21 PDT, Víctor M. Jáquez L. 		no flags
DetailsFormatted DiffDiff
Patch (4.44 KB, patch)
2020-05-28 02:32 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Patch (6.71 KB, patch)
2020-05-28 05:13 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Víctor M. Jáquez L.
Comment 1 2020-05-27 07:21:17 PDT
Created attachment 400332 [details] Patch
Philippe Normand
Comment 2 2020-05-28 02:32:41 PDT
Created attachment 400439 [details] Patch
Philippe Normand
Comment 3 2020-05-28 02:33:14 PDT
Comment on attachment 400439 [details] Patch Can you check if this variant works on your side?
Víctor M. Jáquez L.
Comment 4 2020-05-28 03:07:53 PDT
(In reply to Philippe Normand from comment #3) > Comment on attachment 400439 [details] > Patch > > Can you check if this variant works on your side? It seems not. GST_BUILD_PATH=/home/vjaquez/gst/gst-build Tools/Scripts/build-webkit --gtk --debug --help Building flatpak based environment Building `gst-build` /home/vjaquez/gst/gst-build ninja: Entering directory `/app/webkit/WebKitBuild/gst-build ninja: no work to do. usage: gst-env [-h] [--builddir BUILDDIR] [--srcdir SRCDIR] [--sysroot SYSROOT] [--wine WINE] [--winepath WINEPATH] [--only-environment] optional arguments: -h, --help show this help message and exit --builddir BUILDDIR The meson build directory --srcdir SRCDIR The top level source directory --sysroot SYSROOT The sysroot path used during cross-compilation --wine WINE Build a wine env based on specified wine command --winepath WINEPATH Extra path to set to WINEPATH. --only-environment Do not start a shell, only print required environment.
Philippe Normand
Comment 5 2020-05-28 05:13:00 PDT
Created attachment 400444 [details] Patch
Víctor M. Jáquez L.
Comment 6 2020-05-28 08:38:45 PDT
testing the latest patch, it iterates endlessly on meson reconfiguration.
Philippe Normand
Comment 7 2020-05-28 08:52:21 PDT
Yeah here too, I had to nuke my gst-build build dir, once only though.
Víctor M. Jáquez L.
Comment 8 2020-05-28 11:10:48 PDT
Yep. Removing WebKitBuild/gst-build everything seems to work as expected \o/
EWS
Comment 9 2020-05-29 09:28:31 PDT
Committed r262297: <https://trac.webkit.org/changeset/262297> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400444 [details].
Radar WebKit Bug Importer
Comment 10 2020-05-29 09:29:20 PDT
<rdar://problem/63761780>
Note You need to log in before you can comment on or make changes to this bug.