Bug 212402 – RealtimeIncomingVideoSourceCocoa::OnFrame should use video frame timestamp

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

RealtimeIncomingVideoSourceCocoa::OnFrame should use video frame timestamp

[youenn fablet]

Created attachment 400317 [details]
Patch

[youenn fablet]

Created attachment 400320 [details]
Patch

[Eric Carlson]

Comment on attachment 400320 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400320&action=review

Nice simplification!

> Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm:331
>      while (!m_pendingVideoSampleQueue.isEmpty()) {
> -        if (m_pendingVideoSampleQueue.first()->decodeTime() > now)
> +        auto presentationTime = m_pendingVideoSampleQueue.first()->presentationTime();
> +        if (presentationTime.isValid() && presentationTime > now)
>              break;
>          m_pendingVideoSampleQueue.removeFirst();

Will this do the right thing with 'display immediately' samples?

[youenn fablet]

(In reply to Eric Carlson from comment #3)
> Comment on attachment 400320 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=400320&action=review
> 
> Nice simplification!
> 
> > Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm:331
> >      while (!m_pendingVideoSampleQueue.isEmpty()) {
> > -        if (m_pendingVideoSampleQueue.first()->decodeTime() > now)
> > +        auto presentationTime = m_pendingVideoSampleQueue.first()->presentationTime();
> > +        if (presentationTime.isValid() && presentationTime > now)
> >              break;
> >          m_pendingVideoSampleQueue.removeFirst();
> 
> Will this do the right thing with 'display immediately' samples?

There might indeed be an issue in general.
In practice, for WebRTC usage (which is the sole use of this class), we could probably further simplify and just use one sample as a buffer instead of a duque, since we want to use the newest sample for WebRTC.

[EWS]

Committed r262238: <https://trac.webkit.org/changeset/262238>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400320 [details].

[Radar WebKit Bug Importer]

<rdar://problem/63710172>