Bug 212392 – Use ObjectIdentifier<> instead of uint64_t for context IDs in VideoFullscreenManagerProxy

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Peng Liu]

A follow-up task based on Youenn's comment: https://bugs.webkit.org/show_bug.cgi?id=212293#c3.

[David Kilzer (:ddkilzer)]

<rdar://problem/61799040>

[David Kilzer (:ddkilzer)]

Created attachment 402620 [details]
Patch v1

[youenn fablet]

Comment on attachment 402620 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=402620&action=review

> Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.mm:371
>      MESSAGE_CHECK_CONTEXTID(contextId);

We can remove this one.

> Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.mm:504
>      MESSAGE_CHECK_CONTEXTID(contextId);

Ditto here and above.

> Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:512
>      MESSAGE_CHECK_CONTEXTID(contextId);

Do we need to remove this one as well? Ditto below.

> Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:513
>      MESSAGE_CHECK(videoLayerID);

Should we also use ObjectIdentifier for videoLayerID in the future?

[David Kilzer (:ddkilzer)]

Comment on attachment 402620 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=402620&action=review

Will remove the MESSAGE_CHECK_CONTEXTID() checks as they're redundant now.

Thanks!

>> Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:513
>>      MESSAGE_CHECK(videoLayerID);
> 
> Should we also use ObjectIdentifier for videoLayerID in the future?

Yes, tracked by <rdar://problem/61806253>.

[David Kilzer (:ddkilzer)]

Created attachment 402679 [details]
Patch for landing

[David Kilzer (:ddkilzer)]

Comment on attachment 402679 [details]
Patch for landing

Marking cq+ since changes are only in Source/WebKit, and thus mac-debug-wk1 can't be affected by failed tests.  (I also built macOS Debug locally.)

[EWS]

Committed r263476: <https://trac.webkit.org/changeset/263476>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402679 [details].