Bug 212389 - Sort PlatformEnableCocoa.h and add definitions for the simple cases from FeatureDefines.xcconfig
Summary: Sort PlatformEnableCocoa.h and add definitions for the simple cases from Feat...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-26 15:30 PDT by Darin Adler
Modified: 2020-05-27 10:23 PDT (History)
6 users (show)

See Also:

Attachments
Patch (20.95 KB, patch)
2020-05-26 16:36 PDT, Darin Adler 		andersca: review+
darin: commit-queue+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2020-05-26 15:30:46 PDT 
Sort PlatformEnableCocoa.h and add definitions for the simple cases from FeatureDefines.xcconfig
Comment 1 Darin Adler 2020-05-26 16:36:49 PDT 
Created attachment 400287 [details]
Patch
Comment 2 Anders Carlsson 2020-05-26 21:25:09 PDT 
Comment on attachment 400287 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400287&action=review

> Source/WTF/wtf/PlatformEnableCocoa.h:39
> +/* Please keep the following in alphabetical order so we can notice duplicates. */

Why not use // C++ style comments?
Comment 3 Darin Adler 2020-05-27 10:20:39 PDT 
Comment on attachment 400287 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400287&action=review

>> Source/WTF/wtf/PlatformEnableCocoa.h:39
>> +/* Please keep the following in alphabetical order so we can notice duplicates. */
> 
> Why not use // C++ style comments?

I don’t know. I know these headers are very widely included, even in non-C++ files. But I don’t know if we have to support any language/compiler configuration that does not support them.
Comment 4 Darin Adler 2020-05-27 10:22:37 PDT 
Committed r262199: <https://trac.webkit.org/changeset/262199>
Comment 5 Radar WebKit Bug Importer 2020-05-27 10:23:16 PDT 
<rdar://problem/63679872>