Bug 212378 - IteratorClose should suppress GetMethod errors
Summary: IteratorClose should suppress GetMethod errors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Minor
Assignee: Alexey Shvayka
URL: https://github.com/tc39/ecma262/pull/...
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-26 09:14 PDT by Alexey Shvayka
Modified: 2020-05-26 15:18 PDT (History)
7 users (show)

See Also:

Attachments
Patch (9.41 KB, patch)
2020-05-26 09:17 PDT, Alexey Shvayka 		keith_miller: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Shvayka 2020-05-26 09:14:56 PDT 
IteratorClose should suppress GetMethod errors
Comment 1 Alexey Shvayka 2020-05-26 09:17:57 PDT 
Created attachment 400252 [details]
Patch
Comment 2 Keith Miller 2020-05-26 14:43:09 PDT 
Comment on attachment 400252 [details]
Patch

r=me.

RE, Your offline question about whether emitIteratorGenericClose should take the label. I don't think it's too important either way and I could imagine other places where you don't want the label. I'd leave it as is.
Comment 3 Alexey Shvayka 2020-05-26 15:16:14 PDT 
Committed r262165: <https://trac.webkit.org/changeset/262165>
Comment 4 Radar WebKit Bug Importer 2020-05-26 15:17:13 PDT 
<rdar://problem/63644865>
Comment 5 Alexey Shvayka 2020-05-26 15:18:49 PDT 
(In reply to Keith Miller from comment #2)
> RE, Your offline question about whether emitIteratorGenericClose should take
> the label. I don't think it's too important either way and I could imagine
> other places where you don't want the label. I'd leave it as is.

Thank you, Keith!