Bug 212374 - [css-grid] Import tests for the grid as flexbox item case
Summary: [css-grid] Import tests for the grid as flexbox item case
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Javier Fernandez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-26 06:57 PDT by Javier Fernandez
Modified: 2020-05-29 13:30 PDT (History)
6 users (show)

See Also:

Attachments
Patch (24.75 KB, patch)
2020-05-26 07:28 PDT, Javier Fernandez 		no flags Details | Formatted Diff | Diff
Patch (24.94 KB, patch)
2020-05-27 07:37 PDT, Javier Fernandez 		no flags Details | Formatted Diff | Diff
Patch (31.54 KB, patch)
2020-05-28 15:02 PDT, Javier Fernandez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Javier Fernandez 2020-05-26 06:57:37 PDT 
Import tests from the WPT repository to cover the changes required to fix bug #209282
Comment 1 Javier Fernandez 2020-05-26 07:28:17 PDT 
Created attachment 400243 [details]
Patch
Comment 2 Javier Fernandez 2020-05-27 07:37:20 PDT 
Created attachment 400336 [details]
Patch
Comment 3 Javier Fernandez 2020-05-27 07:39:51 PDT 
These tests were already reviewed and merged upstream [1] so we can land this patch now.


[1] https://github.com/web-platform-tests/wpt/pull/23769
Comment 4 Manuel Rego Casasnovas 2020-05-27 07:56:55 PDT 
Comment on attachment 400336 [details]
Patch

r+
Comment 5 Javier Fernandez 2020-05-28 15:02:44 PDT 
Created attachment 400511 [details]
Patch
Comment 6 EWS 2020-05-29 01:00:48 PDT 
Committed r262284: <https://trac.webkit.org/changeset/262284>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400511 [details].
Comment 7 Radar WebKit Bug Importer 2020-05-29 01:01:20 PDT 
<rdar://problem/63750801>
Comment 8 Truitt Savell 2020-05-29 08:07:58 PDT 
This import introduced 4 new test failures for Mac:
imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-as-flex-item-should-not-shrink-to-fit-001.html
imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-as-flex-item-should-not-shrink-to-fit-003.html
imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-as-flex-item-should-not-shrink-to-fit-007.html
imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-as-flex-item-should-not-shrink-to-fit-008.html

History:
https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-grid%2Flayout-algorithm%2Fgrid-as-flex-item-should-not-shrink-to-fit-001.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-grid%2Flayout-algorithm%2Fgrid-as-flex-item-should-not-shrink-to-fit-003.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-grid%2Flayout-algorithm%2Fgrid-as-flex-item-should-not-shrink-to-fit-007.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-grid%2Flayout-algorithm%2Fgrid-as-flex-item-should-not-shrink-to-fit-008.html

Results:
https://build.webkit.org/results/Apple-Catalina-Release-WK2-Tests/r262292%20(5933)/results.html

The image diff shows a red square for each of these tests.
Comment 9 Jason Lawrence 2020-05-29 08:12:12 PDT 
The failures are being tracked here: https://bugs.webkit.org/show_bug.cgi?id=212525
Comment 10 Truitt Savell 2020-05-29 11:13:05 PDT 
It looks like you marked these as Failure when they should be ImageOnlyFailure
Comment 11 Truitt Savell 2020-05-29 11:15:42 PDT 
Fixed the expectations here: https://trac.webkit.org/changeset/262305/webkit
Comment 12 Javier Fernandez 2020-05-29 13:30:36 PDT 
(In reply to Truitt Savell from comment #11)
> Fixed the expectations here: https://trac.webkit.org/changeset/262305/webkit

Sorry about than and thanks for the fix.