Bug 212362 – Add watchlist comment for patches touching imported WPT tests.

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Carlos Alberto Lopez Perez]

When a WebKit patch touches the imported WPT tests there is a currently script that runs automatically offering to export this changes to the WPT repository.
However this script fails sometimes to create the corresponding WPT PR.

I think it will be useful that we add a style-check trigger so it comments on bugzilla with a link to the wiki with the information about how the export process for WPT tests works.

I have documented how this process works here: https://trac.webkit.org/wiki/WPTExportProcess

[Carlos Alberto Lopez Perez]

Created attachment 400222 [details]
Patch

[EWS Watchlist]

This patch modifies the imported web-platform-tests. Please ensure that any changes on the tests are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

[Carlos Alberto Lopez Perez]

Created attachment 400223 [details]
Patch

[youenn fablet]

Comment on attachment 400223 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400223&action=review

> Tools/Scripts/webkitpy/common/config/watchlist:481
> +        "WebPlatformTests": [ "This patch modifies the imported web-platform-tests. Please ensure that any changes on the tests are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess" ],

Is there a way to not have this message in case only -expected.txt files are changed?
Also, it might be a bit annoying for patches that are resending from upstream.
Will it happen for every patch being uploaded?

[Carlos Alberto Lopez Perez]

(In reply to youenn fablet from comment #4)
> Comment on attachment 400223 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=400223&action=review
> 
> > Tools/Scripts/webkitpy/common/config/watchlist:481
> > +        "WebPlatformTests": [ "This patch modifies the imported web-platform-tests. Please ensure that any changes on the tests are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess" ],
> 
> Is there a way to not have this message in case only -expected.txt files are
> changed?

Yes, I think I can use a negative lookahead regex expression to exclude -expected.txt from the list.

Good idea.


> Also, it might be a bit annoying for patches that are resending from
> upstream.
> Will it happen for every patch being uploaded?

I think it will only comment once (once per bug). It won't comment again on the same bug (even if you upload new patches to the bug).

[Carlos Alberto Lopez Perez]

Created attachment 400248 [details]
Patch

[Carlos Alberto Lopez Perez]

Is this ok now? r?

[youenn fablet]

Comment on attachment 400248 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400248&action=review

> Tools/Scripts/webkitpy/common/config/watchlist:460
> +        "WebPlatformTests": [ "[e-mail]" ],

Can you add [e-mail] as well?

> Tools/Scripts/webkitpy/common/config/watchlist:481
> +        "WebPlatformTests": [ "This patch modifies the imported web-platform-tests. Please ensure that any changes on the tests are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess" ],

s/the imported web-platform-tests/imported WPT tests/

[Carlos Alberto Lopez Perez]

(In reply to youenn fablet from comment #8)
> Comment on attachment 400248 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=400248&action=review
> 
> > Tools/Scripts/webkitpy/common/config/watchlist:460
> > +        "WebPlatformTests": [ "[e-mail]" ],
> 
> Can you add [e-mail] as well?
> 
> > Tools/Scripts/webkitpy/common/config/watchlist:481
> > +        "WebPlatformTests": [ "This patch modifies the imported web-platform-tests. Please ensure that any changes on the tests are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess" ],
> 
> s/the imported web-platform-tests/imported WPT tests/

Ok. Thanks!

[Carlos Alberto Lopez Perez]

Committed r262295: <https://trac.webkit.org/changeset/262295>

[Radar WebKit Bug Importer]

<rdar://problem/63760615>