RESOLVED FIXED 212359
Expose more network metrics to WebCoreNSURLSession 
https://bugs.webkit.org/show_bug.cgi?id=212359
Summary Expose more network metrics to WebCoreNSURLSession
Alex Christensen
Reported 2020-05-25 12:13:26 PDT
Expose more network metrics to WebCoreNSURLSession
Attachments
Patch (8.55 KB, patch)
2020-05-25 12:14 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (8.79 KB, patch)
2020-05-25 16:21 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2020-05-25 12:14:38 PDT
Created attachment 400212 [details] Patch
Darin Adler
Comment 2 2020-05-25 14:29:58 PDT
Comment on attachment 400212 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400212&action=review > Source/WTF/wtf/PlatformHave.h:407 > +#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101500) || (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000) The second half of this expression has the mistake Tim Horton mentioned recently, where it checks IOS_FAMILY, but checks __IPHONE_OS_VERSION_MIN_REQUIRED, which is frozen at an old value on watchOS and tvOS. It should either just check PLATFORM(IOS) and accept this will be false for tvOS and watchOS, or add minimum versions for those platforms.
Alex Christensen
Comment 3 2020-05-25 16:21:23 PDT
Created attachment 400224 [details] Patch
Alex Christensen
Comment 4 2020-05-25 16:22:12 PDT
Comment on attachment 400224 [details] Patch Since the API is public and clearly marked available on all platforms, I'll expand the good pattern in PlatformHave.h.
Darin Adler
Comment 5 2020-05-25 16:26:32 PDT
Comment on attachment 400224 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400224&action=review > Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm:149 > +- (BOOL)cellular Why does the code above say "getter=isCellular" but here it’s named "cellular"? How do we test that this is correctly named or not?
EWS
Comment 6 2020-05-25 17:03:19 PDT
Committed r262131: <https://trac.webkit.org/changeset/262131> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400224 [details].
Radar WebKit Bug Importer
Comment 7 2020-05-25 17:04:22 PDT
<rdar://problem/63607042>
Note You need to log in before you can comment on or make changes to this bug.