Bug 212345 - [css-grid] grid-template-rows can serialize to invalid syntax when set by grid-template
Summary: [css-grid] grid-template-rows can serialize to invalid syntax when set by gri...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oriol Brufau
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-25 05:48 PDT by Oriol Brufau
Modified: 2020-05-25 13:40 PDT (History)
10 users (show)

See Also:


Attachments
Patch (20.87 KB, patch)
2020-05-25 06:46 PDT, Oriol Brufau
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oriol Brufau 2020-05-25 05:48:14 PDT
Run this code:

    document.body.style.gridTemplate = "'s1' [l1] [l2] 's2'";
    document.body.style.gridTemplateRows;

WebKit returns "auto [l1] [l2] auto", which is invalid syntax because, unlike grid-template, grid-template-rows does not accept adjacent <line-names>.

It should return "auto [l1 l2] auto", like Firefox and Chromium do.
Comment 1 Oriol Brufau 2020-05-25 06:46:20 PDT
Created attachment 400197 [details]
Patch
Comment 2 Manuel Rego Casasnovas 2020-05-25 13:21:24 PDT
Comment on attachment 400197 [details]
Patch

r=me, thanks for the fix
Comment 3 EWS 2020-05-25 13:39:49 PDT
Committed r262130: <https://trac.webkit.org/changeset/262130>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400197 [details].
Comment 4 Radar WebKit Bug Importer 2020-05-25 13:40:15 PDT
<rdar://problem/63604814>