Bug 212339 – [Clipboard API] Support reading "image/png" on ClipboardItem

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Wenson Hsieh]

Support reading "image/png" on ClipboardItem

[Radar WebKit Bug Importer]

<rdar://problem/63588957>

[Wenson Hsieh]

Created attachment 400214 [details]
For EWS

[Wenson Hsieh]

Created attachment 400215 [details]
For EWS

[Wenson Hsieh]

Created attachment 400216 [details]
For EWS

[Tim Horton]

Comment on attachment 400216 [details]
For EWS

View in context: https://bugs.webkit.org/attachment.cgi?id=400216&action=review

> Source/WebCore/Modules/async-clipboard/mac/ClipboardImageReaderMac.mm:41
> +        if (auto bitmapData = retainPtr([image TIFFRepresentation])) {
> +            auto bitmapRepresentation = adoptNS([[NSBitmapImageRep alloc] initWithData:bitmapData.get()]);
> +            m_result = Blob::create(SharedBuffer::create([bitmapRepresentation representationUsingType:NSBitmapImageFileTypePNG properties:@{ }]), m_mimeType);

I provided a potential alternative to this double-encode offline.

[Wenson Hsieh]

Comment on attachment 400216 [details]
For EWS

View in context: https://bugs.webkit.org/attachment.cgi?id=400216&action=review

>> Source/WebCore/Modules/async-clipboard/mac/ClipboardImageReaderMac.mm:41
>> +            m_result = Blob::create(SharedBuffer::create([bitmapRepresentation representationUsingType:NSBitmapImageFileTypePNG properties:@{ }]), m_mimeType);
> 
> I provided a potential alternative to this double-encode offline.

👍🏻 Giving it a try, thanks!

[Wenson Hsieh]

Created attachment 400365 [details]
Patch for landing

[EWS]

Committed r262209: <https://trac.webkit.org/changeset/262209>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400365 [details].