Bug 212333 - [GTK4] Implement data list drop down menu
Summary: [GTK4] Implement data list drop down menu
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks: GTK4
  Show dependency tree / graph
 
Reported: 2020-05-24 06:07 PDT by Carlos Garcia Campos
Modified: 2020-06-02 06:06 PDT (History)
2 users (show)

See Also:

Attachments
Patch (7.52 KB, patch)
2020-06-02 05:48 PDT, Carlos Garcia Campos 		aperez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2020-05-24 06:07:57 PDT 
.
Comment 1 Carlos Garcia Campos 2020-06-02 05:48:19 PDT 
Created attachment 400807 [details]
Patch
Comment 2 Adrian Perez 2020-06-02 05:53:54 PDT 
Comment on attachment 400807 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400807&action=review

> Source/WebKit/UIProcess/gtk/WebDataListSuggestionsDropdownGtk.cpp:78
> +#if 0

This “#if 0” looks like a leftover from some testing, it should be
removed before landing the patch.
Comment 3 Carlos Garcia Campos 2020-06-02 06:06:42 PDT 
Committed r262415: <https://trac.webkit.org/changeset/262415>