Bug 212321 - [GTK4] Make inspector work
Summary: [GTK4] Make inspector work
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks: GTK4
  Show dependency tree / graph
 
Reported: 2020-05-24 05:48 PDT by Carlos Garcia Campos
Modified: 2020-06-01 02:24 PDT (History)
5 users (show)

See Also:

Attachments
Patch (11.72 KB, patch)
2020-05-30 05:27 PDT, Carlos Garcia Campos 		aperez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2020-05-24 05:48:53 PDT 
And remote inspector as well.
Comment 1 Carlos Garcia Campos 2020-05-30 05:27:28 PDT 
Created attachment 400664 [details]
Patch
Comment 2 EWS Watchlist 2020-05-30 05:28:30 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Adrian Perez 2020-06-01 01:57:56 PDT 
Comment on attachment 400664 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400664&action=review

> Source/WebKit/ChangeLog:11
> +        (webkitWebViewBaseDispose): Use specific functions to remve the children.

Typo: remve → remove.
Comment 4 Carlos Garcia Campos 2020-06-01 02:24:12 PDT 
Committed r262371: <https://trac.webkit.org/changeset/262371>