Bug 212308 - ASSERTION FAILED: m_clientCounts.contains(contextId) - WebKit::VideoFullscreenManagerProxy::removeClientForContext()
Summary: ASSERTION FAILED: m_clientCounts.contains(contextId) - WebKit::VideoFullscree...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Peng Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-23 17:29 PDT by Peng Liu
Modified: 2020-05-26 09:57 PDT (History)
8 users (show)

See Also:

Attachments
Patch (10.31 KB, patch)
2020-05-23 17:54 PDT, Peng Liu 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peng Liu 2020-05-23 17:29:12 PDT 
ASSERTION FAILED: m_clientCounts.contains(contextId) - WebKit::VideoFullscreenManagerProxy::removeClientForContext()
Comment 1 Peng Liu 2020-05-23 17:30:08 PDT 
<rdar://problem/63511239>
Comment 2 Peng Liu 2020-05-23 17:54:12 PDT 
Created attachment 400145 [details]
Patch
Comment 3 Peng Liu 2020-05-23 17:56:56 PDT 
Any suggestion about the style checking error regarding OS version check? Should we update version_check.py to ignore it?
Comment 4 youenn fablet 2020-05-24 23:57:54 PDT 
Comment on attachment 400145 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400145&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ExitPiPOnSuspendVideoElement.mm:29
> +#if ENABLE(VIDEO_PRESENTATION_MODE) && (PLATFORM(MAC) || (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 140000))

I guess we can leave it as is or introduce a macro in Platform.h.
Comment 5 EWS 2020-05-26 09:57:03 PDT 
Committed r262149: <https://trac.webkit.org/changeset/262149>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400145 [details].