Bug 21229 – NetworkStateNotifier.h lacks a #include <windows.h> for PLATFORM(WIN)

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Darin Fisher (:fishd, Google)]

NetworkStateNotifier.h lacks a #include <windows.h>

This causes build problems if you do not force include windows.h, which seems like an undesirable requirement (to me at least).

[Darin Fisher (:fishd, Google)]

Created attachment 23934 [details]
v1 patch

Simple fix.

[Darin Adler]

Comment on attachment 23934 [details]
v1 patch

r=me

One thing we might want to be more standard about is which basic system headers are handled by either the project file prefix or the "config.h" include file. Those includes won't need to be added in each file that depends on them. I thought <windows.h> was in that category. Also I thought we needed to set some macros like NOMINMAX before including <windows.h> and it was a problem any time the include was in a file "alone" like this.

But I'm not sure of either of those things, it's something we can clean up later, and this seems fine if it's helpful for building Chrome.

[Darin Fisher (:fishd, Google)]

I don't see NOMINMAX defined anywhere.  I do see an entry in ChangeLog-2006-12-31 about it though.  Maybe it got removed later?

[Eric Seidel (no email)]

I'll leave Darin Fisher this patch to commit once his commit-bit gets turned on.

[Darin Adler]

I did a quick search and found that platform/win/COMPtr.h defines NOMINMAX, but that seems like an anomaly. It looks like the NOMINMAX thing is dealt with in WebCore/config.h.

But I also see lots of includes of <windows.h> in various source files in WebCore and JavaScriptCore. It's a slight mystery why we're able to compile NetworkStateNotifier.h on Windows outside Chromium.

[Darin Adler]

http://trac.webkit.org/changeset/37552