Bug 212276 - [IPC] Add support for specifying `Async WantsConnection` in message files
Summary: [IPC] Add support for specifying `Async WantsConnection` in message files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-22 13:36 PDT by Wenson Hsieh
Modified: 2021-07-29 15:18 PDT (History)
5 users (show)

See Also:

Attachments
Patch (9.95 KB, patch)
2020-05-22 14:04 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2020-05-22 13:36:13 PDT 
Example:

    Foo(...) -> (...) Async WantsConnection

...results in this generated code:

    IPC::handleMessageAsync<Messages::WebPageProxy::Foo>(connection, connection, decoder, this, &WebPageProxy::foo);

...which results in a compiler error due to the duplicated `connection` argument.
Comment 1 Wenson Hsieh 2020-05-22 14:04:17 PDT 
Created attachment 400074 [details]
Patch
Comment 2 EWS 2020-05-22 14:45:51 PDT 
Committed r262075: <https://trac.webkit.org/changeset/262075>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400074 [details].
Comment 3 Radar WebKit Bug Importer 2020-05-22 14:46:14 PDT 
<rdar://problem/63554831>