Bug 212265 - Extended Color Cleanup: Make alpha premultiplication code more consistent and clear regarding what works with extended colors
Summary: Extended Color Cleanup: Make alpha premultiplication code more consistent and...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks: 212184
  Show dependency treegraph
 
Reported: 2020-05-22 10:10 PDT by Sam Weinig
Modified: 2020-05-22 13:17 PDT (History)
13 users (show)

See Also:


Attachments
Patch (16.75 KB, patch)
2020-05-22 10:36 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (16.75 KB, patch)
2020-05-22 12:39 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2020-05-22 10:10:06 PDT
Extended Color Cleanup: Make alpha premultiplication code more consistent and clear regarding what works with extended colors
Comment 1 Sam Weinig 2020-05-22 10:36:14 PDT
Created attachment 400055 [details]
Patch
Comment 2 Simon Fraser (smfr) 2020-05-22 12:08:30 PDT
Comment on attachment 400055 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400055&action=review

> Source/WebCore/platform/graphics/ColorUtilities.h:194
> +WEBCORE_EXPORT FloatComponents premultiplyAlpha(const FloatComponents& sRGBCompontents);

Maybe just premultiplied()? "premultiply" sounds like it's in-place, and the "alpha" is a given.
Comment 3 Sam Weinig 2020-05-22 12:39:57 PDT
Created attachment 400065 [details]
Patch
Comment 4 EWS 2020-05-22 13:16:25 PDT
Committed r262070: <https://trac.webkit.org/changeset/262070>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400065 [details].
Comment 5 Radar WebKit Bug Importer 2020-05-22 13:17:15 PDT
<rdar://problem/63551635>