RESOLVED FIXED212265
Extended Color Cleanup: Make alpha premultiplication code more consistent and clear regarding what works with extended colors 
https://bugs.webkit.org/show_bug.cgi?id=212265
Summary Extended Color Cleanup: Make alpha premultiplication code more consistent and...
Sam Weinig
Reported 2020-05-22 10:10:06 PDT
Extended Color Cleanup: Make alpha premultiplication code more consistent and clear regarding what works with extended colors
Attachments
Patch (16.75 KB, patch)
2020-05-22 10:36 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (16.75 KB, patch)
2020-05-22 12:39 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2020-05-22 10:36:14 PDT
Created attachment 400055 [details] Patch
Simon Fraser (smfr)
Comment 2 2020-05-22 12:08:30 PDT
Comment on attachment 400055 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400055&action=review > Source/WebCore/platform/graphics/ColorUtilities.h:194 > +WEBCORE_EXPORT FloatComponents premultiplyAlpha(const FloatComponents& sRGBCompontents); Maybe just premultiplied()? "premultiply" sounds like it's in-place, and the "alpha" is a given.
Sam Weinig
Comment 3 2020-05-22 12:39:57 PDT
Created attachment 400065 [details] Patch
EWS
Comment 4 2020-05-22 13:16:25 PDT
Committed r262070: <https://trac.webkit.org/changeset/262070> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400065 [details].
Radar WebKit Bug Importer
Comment 5 2020-05-22 13:17:15 PDT
<rdar://problem/63551635>
Note You need to log in before you can comment on or make changes to this bug.