Bug 21225 - Machine::retrieveLastCaller should check for a NULL codeBlock
Summary: Machine::retrieveLastCaller should check for a NULL codeBlock
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-29 17:28 PDT by Geoffrey Garen
Modified: 2008-09-29 18:03 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2008-09-29 17:28:06 PDT
Machine::retrieveLastCaller reads a CodeBlock out of the register file without checking for NULL. Since CodeBlocks in the register file can be NULL, it should check.

I thought you could crash this code through something like "console.log.call(console, 'hello world')", but that doesn't quite do it. Still, we should just be safe and check for NULL.
Comment 1 Geoffrey Garen 2008-09-29 18:03:42 PDT
Committed revision 37087.