Bug 212245 – DataTransfer.files contains multiple files when pasting a single image with multiple representations

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Wenson Hsieh]

<rdar://problem/60240436>

[Wenson Hsieh]

Created attachment 400010 [details]
Patch

[Tim Horton]

Comment on attachment 400010 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400010&action=review

> Tools/DumpRenderTree/mac/DumpRenderTreePasteboard.mm:246
> -    _writtenPasteboardItems = adoptNS([[NSMutableArray<NSPasteboardItem *> alloc] initWithCapacity:objects.count]);
> +    auto items = adoptNS([[NSMutableArray<NSPasteboardItem *> alloc] initWithCapacity:objects.count]);

It looks funny to see the type specialization there! But I guess it is fine.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:58
> +    for (NSDictionary <NSString *, NSData *> *typesAndData in items) {

No space before the < ... I /think/?

[Wenson Hsieh]

Comment on attachment 400010 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400010&action=review

>> Tools/DumpRenderTree/mac/DumpRenderTreePasteboard.mm:246
>> +    auto items = adoptNS([[NSMutableArray<NSPasteboardItem *> alloc] initWithCapacity:objects.count]);
> 
> It looks funny to see the type specialization there! But I guess it is fine.

😎

>> Tools/TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:58
>> +    for (NSDictionary <NSString *, NSData *> *typesAndData in items) {
> 
> No space before the < ... I /think/?

Ah, that’s right — it’s only a space before the < if it’s for a @protocol, IIRC.

[Wenson Hsieh]

Created attachment 400023 [details]
Patch for landing

[EWS]

Committed r262047: <https://trac.webkit.org/changeset/262047>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400023 [details].

[Wenson Hsieh]

*** Bug 215145 has been marked as a duplicate of this bug. ***