Bug 212243 – iOS: Pressing tab in the Mail subject field moves focus to the body, but pressing shift tab doesn't move it back

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tim Horton]

iOS: Pressing tab in the Mail subject field moves focus to the body, but pressing shift tab doesn't move it back

[Tim Horton]

Created attachment 400004 [details]
Patch

[Tim Horton]

<rdar://problem/59127764>

[Tim Horton]

*** Bug 212242 has been marked as a duplicate of this bug. ***

[Wenson Hsieh]

Comment on attachment 400004 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400004&action=review

> Source/WebCore/page/FocusController.cpp:453
> +    Document* document = focusedOrMainFrame().document();

I think we generally prefer the strong ref here, as it’s not clear that the code below won’t nuke document.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:847
> +    TestWebKitAPI::Util::run(&delegate.get()->_done);

Nit - I don’t think you need the .get() here.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:862
> +    TestWebKitAPI::Util::run(&delegate.get()->_done);

Ditto.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:876
> +    TestWebKitAPI::Util::run(&delegate.get()->_didSendKeyEvent);

Ditto.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:878
> +    ASSERT_FALSE(delegate.get()->_done);

Ditto.

[Tim Horton]

Created attachment 400035 [details]
Patch

[EWS]

Committed r262051: <https://trac.webkit.org/changeset/262051>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400035 [details].