RESOLVED FIXED21224
Store the callee ScopeChain, not the caller ScopeChain, in the call frame header 
https://bugs.webkit.org/show_bug.cgi?id=21224
Summary Store the callee ScopeChain, not the caller ScopeChain, in the call frame header
Geoffrey Garen
Reported 2008-09-29 16:03:41 PDT
Patch coming.
Attachments
patch (89.48 KB, patch)
2008-09-29 16:04 PDT, Geoffrey Garen 		zwarich: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2008-09-29 16:04:09 PDT
Created attachment 23922 [details] patch Still running the rest of the performance tests, but this is ready for review.
Cameron Zwarich (cpst)
Comment 2 2008-09-29 16:36:36 PDT
Comment on attachment 23922 [details] patch There is a typo in the ChangeLog: "Exec::m_scopeChain" should be "ExecState::m_scopeChain". You should add a test for the big you say you fixed, but you told me you will do that. + // FIXME: callerCodeBlock can be NULL. You should make a bug for this and add the bug number to the FIXME. + for ( ; exec; exec = exec->m_prev) Most of these in our code are of the form "for (; " with no space between the '(' and the ';'. Other than that, r=me.
Geoffrey Garen
Comment 3 2008-09-29 17:45:34 PDT
> There is a typo in the ChangeLog: "Exec::m_scopeChain" should be > "ExecState::m_scopeChain". Fixed. > You should add a test for the big you say you fixed, but you told me you will > do that. Fixed. > + // FIXME: callerCodeBlock can be NULL. > > You should make a bug for this and add the bug number to the FIXME. Added a bug. Removed the FIXME. FIXMEs are not so good for tracking future work. My bad. > + for ( ; exec; exec = exec->m_prev) > > Most of these in our code are of the form "for (; " with no space between the > '(' and the ';'. Fixed. Thanks!
Geoffrey Garen
Comment 4 2008-09-29 17:46:42 PDT
Committed revision 37086.
Note You need to log in before you can comment on or make changes to this bug.