Bug 212238 - Fix some thread safety issues with ScrollController timers
Summary: Fix some thread safety issues with ScrollController timers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-21 16:10 PDT by Simon Fraser (smfr)
Modified: 2020-05-21 19:37 PDT (History)
9 users (show)

See Also:


Attachments
Patch (31.32 KB, patch)
2020-05-21 16:17 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (30.85 KB, patch)
2020-05-21 16:41 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (31.05 KB, patch)
2020-05-21 16:48 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (31.41 KB, patch)
2020-05-21 16:56 PDT, Simon Fraser (smfr)
wenson_hsieh: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2020-05-21 16:10:55 PDT
Fix some thread safety issues with ScrollController timers
Comment 1 Simon Fraser (smfr) 2020-05-21 16:17:08 PDT
Created attachment 399995 [details]
Patch
Comment 2 Wenson Hsieh 2020-05-21 16:27:40 PDT
Comment on attachment 399995 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399995&action=review

> Source/WebCore/ChangeLog:14
> +        timers would grap the main thread runloop. Fix by creating the timers on demand.

“grap”

> Source/WebCore/page/scrolling/mac/ScrollingTreeOverflowScrollingNodeMac.h:56
> +    void wasBeRemovedFromTree() final;

“wasBe"

> Source/WebCore/platform/Logging.cpp:93
> +    LogScrolling.state = WTFLogChannelState::On;

I don’t think you meant to add this.
Comment 3 Simon Fraser (smfr) 2020-05-21 16:41:11 PDT
Created attachment 399998 [details]
Patch
Comment 4 Simon Fraser (smfr) 2020-05-21 16:48:42 PDT
Created attachment 399999 [details]
Patch
Comment 5 Simon Fraser (smfr) 2020-05-21 16:56:25 PDT
Created attachment 400001 [details]
Patch
Comment 6 Wenson Hsieh 2020-05-21 18:03:26 PDT
Comment on attachment 400001 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400001&action=review

> Source/WebCore/ChangeLog:49
> +        * platform/Logging.cpp:
> +        (WebCore::initializeLogChannelsIfNecessary):

Nit - you can remove this.
Comment 7 Simon Fraser (smfr) 2020-05-21 19:36:44 PDT
https://trac.webkit.org/changeset/262042/webkit
Comment 8 Radar WebKit Bug Importer 2020-05-21 19:37:24 PDT
<rdar://problem/63524050>