WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
212238
Fix some thread safety issues with ScrollController timers
https://bugs.webkit.org/show_bug.cgi?id=212238
Summary
Fix some thread safety issues with ScrollController timers
Simon Fraser (smfr)
Reported
2020-05-21 16:10:55 PDT
Fix some thread safety issues with ScrollController timers
Attachments
Patch
(31.32 KB, patch)
2020-05-21 16:17 PDT
,
Simon Fraser (smfr)
no flags
Details
Formatted Diff
Diff
Patch
(30.85 KB, patch)
2020-05-21 16:41 PDT
,
Simon Fraser (smfr)
no flags
Details
Formatted Diff
Diff
Patch
(31.05 KB, patch)
2020-05-21 16:48 PDT
,
Simon Fraser (smfr)
no flags
Details
Formatted Diff
Diff
Patch
(31.41 KB, patch)
2020-05-21 16:56 PDT
,
Simon Fraser (smfr)
wenson_hsieh
: review+
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2020-05-21 16:17:08 PDT
Created
attachment 399995
[details]
Patch
Wenson Hsieh
Comment 2
2020-05-21 16:27:40 PDT
Comment on
attachment 399995
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=399995&action=review
> Source/WebCore/ChangeLog:14 > + timers would grap the main thread runloop. Fix by creating the timers on demand.
“grap”
> Source/WebCore/page/scrolling/mac/ScrollingTreeOverflowScrollingNodeMac.h:56 > + void wasBeRemovedFromTree() final;
“wasBe"
> Source/WebCore/platform/Logging.cpp:93 > + LogScrolling.state = WTFLogChannelState::On;
I don’t think you meant to add this.
Simon Fraser (smfr)
Comment 3
2020-05-21 16:41:11 PDT
Created
attachment 399998
[details]
Patch
Simon Fraser (smfr)
Comment 4
2020-05-21 16:48:42 PDT
Created
attachment 399999
[details]
Patch
Simon Fraser (smfr)
Comment 5
2020-05-21 16:56:25 PDT
Created
attachment 400001
[details]
Patch
Wenson Hsieh
Comment 6
2020-05-21 18:03:26 PDT
Comment on
attachment 400001
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=400001&action=review
> Source/WebCore/ChangeLog:49 > + * platform/Logging.cpp: > + (WebCore::initializeLogChannelsIfNecessary):
Nit - you can remove this.
Simon Fraser (smfr)
Comment 7
2020-05-21 19:36:44 PDT
https://trac.webkit.org/changeset/262042/webkit
Radar WebKit Bug Importer
Comment 8
2020-05-21 19:37:24 PDT
<
rdar://problem/63524050
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug