The spec <https://drafts.csswg.org/css-grid/#grid-items> states that child text runs containing only white space should not rendered (just as if its text nodes were display:none) There is WPT testing this https://wpt.live/css/css-grid/grid-items/whitespace-in-grid-item-001.html (or layout-test imported/w3c/web-platform-tests/css/css-grid/grid-items/whitespace-in-grid-item-001.html ) This test passes both on Chrome and Firefox. For the related chrome issue see: https://codereview.chromium.org/16888008
Created attachment 399967 [details] Patch
Comment on attachment 399967 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399967&action=review r=me, but please wait for green EWSs before landing. > Source/WebCore/rendering/updating/RenderTreeUpdater.cpp:432 > if (parentRenderer.isFlexibleBox() && !parentRenderer.isRenderButton()) Mmm, ok I see the condition for flexbox in this line, usually we have both conditions together. Not a big deal but maybe we can just join both ifs.
Created attachment 399978 [details] Patch
I have joined both conditionals and updated the expectation of simple-line-layout-with-zero-sized-font.html I worried that this patch could defeat the purpose of that crashtest, but I have tried reverting the patch from bug 164076 and the test doesn't crash anyways.
Comment on attachment 399978 [details] Patch r=me, thanks.
Comment on attachment 399978 [details] Patch EWS is green now
Committed r262033: <https://trac.webkit.org/changeset/262033> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399978 [details].
<rdar://problem/63515126>