Bug 212216 - REGRESSION(r261922): [GTK][WPE] imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set.html is failing
Summary: REGRESSION(r261922): [GTK][WPE] imported/w3c/web-platform-tests/html/semantic...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Diego Pino
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-21 09:22 PDT by Diego Pino
Modified: 2020-05-25 01:38 PDT (History)
3 users (show)

See Also:


Attachments
Patch (21.17 KB, patch)
2020-05-25 01:36 PDT, Diego Pino
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Pino 2020-05-21 09:22:06 PDT
The test started failing in the range r261922-r261929. I bisected the range and the regression started happening in r261922.

Diff: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r261992%20(13799)/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set-diff.txt

--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set-actual.txt
@@ -61,9 +61,9 @@
 PASS <picture><source srcset="data:,b" type="text/html"><img src="data:,a" data-expect="data:,a"></picture>
 PASS <picture><source srcset="data:,b" type="text/plain"><img src="data:,a" data-expect="data:,a"></picture>
 PASS <picture><source srcset="data:,b" type="text/css"><img src="data:,a" data-expect="data:,a"></picture>
-PASS <picture><source srcset="data:,b" type="video/mp4"><img src="data:,a" data-expect="data:,a"></picture>
-PASS <picture><source srcset="data:,b" type="video/ogg"><img src="data:,a" data-expect="data:,a"></picture>
-PASS <picture><source srcset="data:,b" type="video/webm"><img src="data:,a" data-expect="data:,a"></picture>
+FAIL <picture><source srcset="data:,b" type="video/mp4"><img src="data:,a" data-expect="data:,a"></picture> assert_equals: expected "data:,a" but got "data:,b"
+FAIL <picture><source srcset="data:,b" type="video/ogg"><img src="data:,a" data-expect="data:,a"></picture> assert_equals: expected "data:,a" but got "data:,b"
+FAIL <picture><source srcset="data:,b" type="video/webm"><img src="data:,a" data-expect="data:,a"></picture> assert_equals: expected "data:,a" but got "data:,b"
 PASS <picture><source srcset="data:,b" type="unknown/unknown"><img src="data:,a" data-expect="data:,a"></picture>
 PASS <picture><source srcset="data:,b" type="application/octet-stream"><img src="data:,a" data-expect="data:,a"></picture>
 PASS <picture><source srcset="data:,b" type="application/x-shockwave-flash"><img src="data:,a" data-expect="data:,a"></picture>
Comment 1 Philippe Normand 2020-05-22 02:22:03 PDT
This needs a rebaseline, like on mac and ios. The test assumes <img> doesn't support video, but this is no longer the case in WPE and GTK now that we have a video decoder for the img tag.
Comment 2 Fred 2020-05-22 23:05:56 PDT Comment hidden (spam)
Comment 3 Diego Pino 2020-05-25 01:36:13 PDT
Created attachment 400186 [details]
Patch
Comment 4 Diego Pino 2020-05-25 01:37:47 PDT
Committed r262118: <https://trac.webkit.org/changeset/262118>
Comment 5 Radar WebKit Bug Importer 2020-05-25 01:38:13 PDT
<rdar://problem/63591716>