Bug 21220 - Show the node highlight all the time when hovering
: Show the node highlight all the time when hovering
: WebKit
Web Inspector (Deprecated)
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To:
: InRadar
  Show dependency treegraph
Reported: 2008-09-29 13:30 PST by
Modified: 2008-09-29 15:34 PST (History)

Proposed patch (23.56 KB, patch)
2008-09-29 13:37 PST, Timothy Hatcher
kmccullough: review+
Review Patch | Details | Formatted Diff | Diff


You need to log in before you can comment on or make changes to this bug.

Description From 2008-09-29 13:30:52 PST
We should show the node highlight all the time when hovering in the DOM tree.
------- Comment #1 From 2008-09-29 13:37:12 PST -------
Created an attachment (id=23919) [details]
Proposed patch
------- Comment #2 From 2008-09-29 14:01:21 PST -------
Didn't we intentionally revert this behavior a while back?
------- Comment #3 From 2008-09-29 14:03:42 PST -------
Yes, but that was when we scrolled to reveal the node. Now that we don't do this, the highlight is not annoying to use and better matches Firebug. Our current behavior is confusing developers too. <rdar://problem/6118902>
------- Comment #4 From 2008-09-29 14:08:11 PST -------
Also this patch requires hovering a node for 500ms before the highlight shows. (The previous attempt highlighted the instant you hovered.) This new behavior makes it less twitchy and behaves like a tooltip (hover to get it, then hover to the next element hows the highlight faster).

Plus the feedback about the previous implementation said there was no feedback in the inspector. We now have a hover effect in the inspector too so you see the row for the node you are over. So there is a tie between the two.
------- Comment #5 From 2008-09-29 15:26:34 PST -------
(From update of attachment 23919 [details])
change "sooner if there if one is already showing" to "sooner if there is one already showing"

could move the setting of element on line 180 to 195 in ElementsTreeOutline.prototype
------- Comment #6 From 2008-09-29 15:34:41 PST -------
Landed in r37079.