Bug 21220 - Show the node highlight all the time when hovering
: Show the node highlight all the time when hovering
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated)
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To: Timothy Hatcher
: InRadar
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-09-29 13:30 PDT by Timothy Hatcher
Modified: 2008-09-29 15:34 PDT (History)
3 users (show)

See Also:


Attachments
Proposed patch (23.56 KB, patch)
2008-09-29 13:37 PDT, Timothy Hatcher
kmccullough: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2008-09-29 13:30:52 PDT
We should show the node highlight all the time when hovering in the DOM tree.
Comment 1 Timothy Hatcher 2008-09-29 13:37:12 PDT
Created attachment 23919 [details]
Proposed patch
Comment 2 Adam Roben (:aroben) 2008-09-29 14:01:21 PDT
Didn't we intentionally revert this behavior a while back?
Comment 3 Timothy Hatcher 2008-09-29 14:03:42 PDT
Yes, but that was when we scrolled to reveal the node. Now that we don't do this, the highlight is not annoying to use and better matches Firebug. Our current behavior is confusing developers too. <rdar://problem/6118902>
Comment 4 Timothy Hatcher 2008-09-29 14:08:11 PDT
Also this patch requires hovering a node for 500ms before the highlight shows. (The previous attempt highlighted the instant you hovered.) This new behavior makes it less twitchy and behaves like a tooltip (hover to get it, then hover to the next element hows the highlight faster).

Plus the feedback about the previous implementation said there was no feedback in the inspector. We now have a hover effect in the inspector too so you see the row for the node you are over. So there is a tie between the two.
Comment 5 Kevin McCullough 2008-09-29 15:26:34 PDT
Comment on attachment 23919 [details]
Proposed patch

change "sooner if there if one is already showing" to "sooner if there is one already showing"

could move the setting of element on line 180 to 195 in ElementsTreeOutline.prototype
Comment 6 Timothy Hatcher 2008-09-29 15:34:41 PDT
Landed in r37079.