RESOLVED FIXED212178
Add an option that exposes functions on the global object to turn on and off the sampling profiler and the super sampler 
https://bugs.webkit.org/show_bug.cgi?id=212178
Summary Add an option that exposes functions on the global object to turn on and off ...
Saam Barati
Reported 2020-05-20 16:49:08 PDT
These are helpful to have them only enable in a certain range of code. For example, when profiling Speedometer, it's useful to have them only on when running actual benchmark code. This allows you to fiddle with the UI without worry that those actions are being measured and accounted for.
Attachments
patch (8.41 KB, patch)
2020-05-20 18:28 PDT, Saam Barati 		ysuzuki: review+
DetailsFormatted DiffDiff
patch for landing (8.49 KB, patch)
2020-05-20 22:04 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2020-05-20 18:28:19 PDT
Created attachment 399922 [details] patch
Yusuke Suzuki
Comment 2 2020-05-20 18:31:25 PDT
Comment on attachment 399922 [details] patch r=me
Mark Lam
Comment 3 2020-05-20 19:11:50 PDT
The 32-bit build failure is real. Can you fix?
Saam Barati
Comment 4 2020-05-20 19:49:18 PDT
(In reply to Mark Lam from comment #3) > The 32-bit build failure is real. Can you fix? Will do before landing. Just needs an ENABLE(SAMPLING_PROFILER)
Saam Barati
Comment 5 2020-05-20 22:04:01 PDT
Created attachment 399932 [details] patch for landing
EWS
Comment 6 2020-05-21 10:44:17 PDT
Committed r262014: <https://trac.webkit.org/changeset/262014> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399932 [details].
Radar WebKit Bug Importer
Comment 7 2020-05-21 10:45:18 PDT
<rdar://problem/63500143>
Note You need to log in before you can comment on or make changes to this bug.