Bug 212178 - Add an option that exposes functions on the global object to turn on and off the sampling profiler and the super sampler
Summary: Add an option that exposes functions on the global object to turn on and off ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-20 16:49 PDT by Saam Barati
Modified: 2020-05-21 10:45 PDT (History)
14 users (show)

See Also:

Attachments
patch (8.41 KB, patch)
2020-05-20 18:28 PDT, Saam Barati 		ysuzuki: review+
Details | Formatted Diff | Diff
patch for landing (8.49 KB, patch)
2020-05-20 22:04 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2020-05-20 16:49:08 PDT 
These are helpful to have them only enable in a certain range of code. For example, when profiling Speedometer, it's useful to have them only on when running actual benchmark code. This allows you to fiddle with the UI without worry that those actions are being measured and accounted for.
Comment 1 Saam Barati 2020-05-20 18:28:19 PDT 
Created attachment 399922 [details]
patch
Comment 2 Yusuke Suzuki 2020-05-20 18:31:25 PDT 
Comment on attachment 399922 [details]
patch

r=me
Comment 3 Mark Lam 2020-05-20 19:11:50 PDT 
The 32-bit build failure is real.  Can you fix?
Comment 4 Saam Barati 2020-05-20 19:49:18 PDT 
(In reply to Mark Lam from comment #3)
> The 32-bit build failure is real.  Can you fix?

Will do before landing. Just needs an ENABLE(SAMPLING_PROFILER)
Comment 5 Saam Barati 2020-05-20 22:04:01 PDT 
Created attachment 399932 [details]
patch for landing
Comment 6 EWS 2020-05-21 10:44:17 PDT 
Committed r262014: <https://trac.webkit.org/changeset/262014>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399932 [details].
Comment 7 Radar WebKit Bug Importer 2020-05-21 10:45:18 PDT 
<rdar://problem/63500143>