Bug 212169 - [iOS] Layout tests in editing/pasteboard sporadically crash
Summary: [iOS] Layout tests in editing/pasteboard sporadically crash
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-20 14:40 PDT by Wenson Hsieh
Modified: 2020-05-23 05:58 PDT (History)
6 users (show)

See Also:


Attachments
Patch (2.50 KB, patch)
2020-05-20 14:50 PDT, Wenson Hsieh
thorton: review+
Details | Formatted Diff | Diff
Patch for landing (1.88 KB, patch)
2020-05-20 16:00 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2020-05-20 14:40:31 PDT
<rdar://problem/63361966>
Comment 1 Wenson Hsieh 2020-05-20 14:50:04 PDT
Created attachment 399895 [details]
Patch
Comment 2 Wenson Hsieh 2020-05-20 14:53:37 PDT
Comment on attachment 399895 [details]
Patch

Thanks for the review!
Comment 3 Wenson Hsieh 2020-05-20 15:58:25 PDT
The DumpRenderTree EWS failures _might_ be caused by this change, but I can’t tell for sure. For the time being, I’ll revert changes to DumpRenderTree, as they’re not needed to fix this bug (and we don’t run WebKit1 tests on iOS in automation anyways).
Comment 4 Wenson Hsieh 2020-05-20 16:00:08 PDT
Created attachment 399903 [details]
Patch for landing
Comment 5 EWS 2020-05-20 16:42:25 PDT
Committed r261972: <https://trac.webkit.org/changeset/261972>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399903 [details].