Bug 212156 – [Mac,WK2] Fullscreen animation missing a few frames at beginning

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

Fullscreen animation missing a few frames at beginning

[Jer Noble]

<rdar://problem/54799415>

[Jer Noble]

Created attachment 399863 [details]
Patch

[Eric Carlson]

Comment on attachment 399863 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399863&action=review

> Source/WebKit/ChangeLog:9
> +        When starting the animation, ensure that the fullscreen window is ordered front, and on top

s/the animation/the enter fullscreen animation/

> Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm:325
> +    [clipLayer addAnimation:zoomAnimation(_initialFrame, _finalFrame, self.window.screen.frame, 1e10, AnimateIn) forKey:@"fullscreen"];
> +    clipLayer.mask = createMask(contentView.bounds);
> +    [clipLayer.mask addAnimation:maskAnimation(_initialFrame, _finalFrame, self.window.screen.frame, 1e10, AnimateIn) forKey:@"fullscreen"];

`1e10` probably deserves a named constant to make it clear why we use it.

[Jer Noble]

Created attachment 400360 [details]
Patch for landing

Addressed Eric's comments. Rather than giving the duration an arbitrarily long duration, we just give the animations a duration value of 1 and a speed of 0.

[EWS]

Committed r262322: <https://trac.webkit.org/changeset/262322>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400360 [details].