after the changes in https://trac.webkit.org/changeset/261892/webkit This test is failing: TestWebKitAPI.ResourceLoadStatistics.MigrateDataFromMissingTopFrameUniqueRedirectSameSiteStrictTableSchema and these are timing out: TestWebKitAPI.ResourceLoadStatistics.NetworkProcessRestart TestWebKitAPI.ResourceLoadStatistics.ShouldNotGrandfatherOnStartupDatabase TestWebKitAPI.ResourceLoadStatistics.ShouldNotGrandfatherOnStartup Result output: https://build.webkit.org/builders/Apple-Catalina-Debug-WK2-Tests/builds/4380/steps/run-api-tests/logs/stdio
<rdar://problem/63452541>
It looks like this test is specifically broken on Mojave Debug: TestWebKitAPI.ResourceLoadStatistics.NoMessagesWhenNotTesting History: https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.ResourceLoadStatistics.NoMessagesWhenNotTesting
Created attachment 399851 [details] Patch
I got a little too excited when deleting reset() calls in https://trac.webkit.org/changeset/261892/webkit. In this case it is needed because this statement is initialized in this function and does not use SQLiteStatementAutoResetScope, so it must be reset between iterations of the loop.
Committed r261935: <https://trac.webkit.org/changeset/261935> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399851 [details].