Bug 212142 - Fix for accessibility-node-memory-management.html in isolated tree mode.
Summary: Fix for accessibility-node-memory-management.html in isolated tree mode.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-20 08:46 PDT by Andres Gonzalez
Modified: 2020-05-20 11:22 PDT (History)
9 users (show)

See Also:


Attachments
Patch (5.64 KB, patch)
2020-05-20 08:57 PDT, Andres Gonzalez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2020-05-20 08:46:24 PDT
Fix for accessibility-node-memory-management.html in isolated tree mode.
Comment 1 Andres Gonzalez 2020-05-20 08:57:23 PDT
Created attachment 399842 [details]
Patch
Comment 2 chris fleizach 2020-05-20 09:12:50 PDT
Comment on attachment 399842 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399842&action=review

> Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:380
>          auto& wrapper = item.m_wrapper ? item.m_wrapper : item.m_isolatedObject->wrapper();

is this a pointer? should we be using auto& ?
Comment 3 Andres Gonzalez 2020-05-20 10:55:09 PDT
(In reply to chris fleizach from comment #2)
> Comment on attachment 399842 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=399842&action=review
> 
> > Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:380
> >          auto& wrapper = item.m_wrapper ? item.m_wrapper : item.m_isolatedObject->wrapper();
> 
> is this a pointer? should we be using auto& ?

I believe it is ok because wrapper is a reference to either NodeChange::m_wrapper or AXCoreObject::m_wrapper, which is a RetainPtr.
Comment 4 EWS 2020-05-20 11:21:14 PDT
Committed r261934: <https://trac.webkit.org/changeset/261934>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399842 [details].
Comment 5 Radar WebKit Bug Importer 2020-05-20 11:22:15 PDT
<rdar://problem/63455951>