Bug 212140 - Disable support for BeforeLoadEvent
Summary: Disable support for BeforeLoadEvent
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-20 08:32 PDT by Chris Dumez
Modified: 2021-11-20 23:49 PST (History)
18 users (show)

See Also:

Attachments
Patch (7.90 KB, patch)
2020-05-20 08:47 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (127.56 KB, patch)
2020-05-20 09:40 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (156.07 KB, patch)
2020-05-20 10:45 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (156.02 KB, patch)
2020-05-20 10:52 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (156.03 KB, patch)
2020-05-20 10:54 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (147.92 KB, patch)
2020-05-20 11:05 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (147.89 KB, patch)
2020-05-20 11:20 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (156.05 KB, patch)
2020-05-20 11:26 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (155.96 KB, patch)
2020-05-20 11:50 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (8) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-05-20 08:32:39 PDT 
Disable support for BeforeLoadEvent. Other browsers do not support it and Chrome dropped it shortly after the fork:
https://bugs.chromium.org/p/chromium/issues/detail?id=333318

This is a synchronous event and therefore a frequent source of security bugs.
Comment 1 Chris Dumez 2020-05-20 08:32:56 PDT 
<rdar://problem/62847577>
Comment 2 Chris Dumez 2020-05-20 08:47:00 PDT 
Created attachment 399841 [details]
Patch
Comment 3 Chris Dumez 2020-05-20 09:40:01 PDT 
Created attachment 399846 [details]
Patch
Comment 4 Chris Dumez 2020-05-20 10:45:28 PDT 
Created attachment 399852 [details]
Patch
Comment 5 Chris Dumez 2020-05-20 10:52:00 PDT 
Created attachment 399854 [details]
Patch
Comment 6 Chris Dumez 2020-05-20 10:54:56 PDT 
Created attachment 399855 [details]
Patch
Comment 7 Chris Dumez 2020-05-20 11:01:23 PDT 
Trying to figure out why the bots won't apply my patch anymore... even though I rebased it 3 times already.
Comment 8 Chris Dumez 2020-05-20 11:05:32 PDT 
Created attachment 399857 [details]
Patch
Comment 9 Chris Dumez 2020-05-20 11:11:48 PDT 
The issue seems to be that I am removing LayoutTests/http/tests/cache/cancel-during-revalidation-succeeded.html and this test has weird end of line characters. Not sure how to make bugzilla like my patch yet...
Comment 10 Chris Dumez 2020-05-20 11:20:44 PDT 
Created attachment 399859 [details]
Patch
Comment 11 Chris Dumez 2020-05-20 11:26:41 PDT 
Created attachment 399860 [details]
Patch
Comment 12 Chris Dumez 2020-05-20 11:50:47 PDT 
Created attachment 399865 [details]
Patch
Comment 13 EWS 2020-05-20 13:14:28 PDT 
Committed r261946: <https://trac.webkit.org/changeset/261946>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399865 [details].
Comment 14 Ryan Haddad 2020-05-20 16:39:00 PDT 
(In reply to EWS from comment #13)
> Committed r261946: <https://trac.webkit.org/changeset/261946>
As win-ews noted, this caused two test failures for Windows.

Fixed them with rebaselines in r261971.
Comment 15 Chris Dumez 2020-05-20 16:39:24 PDT 
(In reply to Ryan Haddad from comment #14)
> (In reply to EWS from comment #13)
> > Committed r261946: <https://trac.webkit.org/changeset/261946>
> As win-ews noted, this caused two test failures for Windows.
> 
> Fixed them with rebaselines in r261971.

Thank you Ryan.
Comment 16 routerpipe 2021-11-20 23:49:43 PST 
Many addons use this event beforeload to block advert , can we recovery this feature