Bug 212136 - REGRESSION(r261554): [GTK] Version 2.29.1 crashes using drag-n-drop API
Summary: REGRESSION(r261554): [GTK] Version 2.29.1 crashes using drag-n-drop API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-20 07:26 PDT by Guilaume Ayoub
Modified: 2020-05-20 16:04 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.37 KB, patch)
2020-05-20 08:24 PDT, Carlos Garcia Campos
aperez: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Guilaume Ayoub 2020-05-20 07:26:22 PDT
When using the drag-n-drop API, Epiphany with WebKitGTK 2.29.1 crashes. Previous versions of WebKitGTK were working.

Example: https://jsbin.com/hiqasek/edit?html,js,output

- Epiphany 3.37.1
- WebKitGTK 2.29.1
Comment 1 Carlos Garcia Campos 2020-05-20 08:22:58 PDT
Right, I forgot to handle selection data in Pasteboard::read taking a PasteboardFileReader.
Comment 2 Carlos Garcia Campos 2020-05-20 08:24:50 PDT
Created attachment 399840 [details]
Patch
Comment 3 Carlos Garcia Campos 2020-05-20 09:00:06 PDT
Committed r261923: <https://trac.webkit.org/changeset/261923>
Comment 4 Guilaume Ayoub 2020-05-20 16:04:46 PDT
That was really, really fast. Thank you ♥, the patch works perfectly!