Bug 212126 – [GTK4] Build error with gtk4 on PluginProcessMainUnix.cpp

• Status: RESOLVED
• Resolution: WONTFIX
• Component: Platform

[Santosh Mahto]

In gtk4, gtk_init doesn't take any command line arguments, but PluginProcessMainUnix.cpp still uses the gtk3 based gtk_init call.
which result in error while building with gtk4

[Santosh Mahto]

Created attachment 399809 [details]
Patch

[Santosh Mahto]

It would be nice if

[Santosh Mahto]

It would be nice if someone can review this simple build error fix for gtk4

[Santosh Mahto]

Created attachment 399810 [details]
Patch

[Adrian Perez]

Comment on attachment 399810 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399810&action=review

> Source/WebKit/ChangeLog:8
> +        * PluginProcess/unix/PluginProcessMainUnix.cpp:

NPAPI plug-in support is disabled for GTK4 builds. We are not planning
to support them, given that all major browsers are phasing out the support
(or have already).

> Source/WebKit/PluginProcess/unix/PluginProcessMainUnix.cpp:64
>          gtk_init(nullptr, nullptr);

…anyway, instead of doing this, you should leave the call to gtk_init()
unchanged and instead the <WebCore/GtkVersioning.h>, which has utility
functions that avoid the need for preprocessor guards.

[Santosh Mahto]

(In reply to Adrian Perez from comment #5)
> Comment on attachment 399810 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=399810&action=review
> 
> > Source/WebKit/ChangeLog:8
> > +        * PluginProcess/unix/PluginProcessMainUnix.cpp:
> 
> NPAPI plug-in support is disabled for GTK4 builds. We are not planning
> to support them, given that all major browsers are phasing out the support
> (or have already).
> 
> > Source/WebKit/PluginProcess/unix/PluginProcessMainUnix.cpp:64
> >          gtk_init(nullptr, nullptr);
> 
> …anyway, instead of doing this, you should leave the call to gtk_init()
> unchanged and instead the <WebCore/GtkVersioning.h>, which has utility
> functions that avoid the need for preprocessor guards.


Thanks for review,
I will update the patch with WebCore/GtkVersioning.h inclusion, If you feel it should be part of main tree(at least until PluginProcessMainUnix.cpp code is removed), you can further review/merge it.

[Santosh Mahto]

Created attachment 399824 [details]
Patch

[Michael Catanzaro]

$0.02: I think it's time to delete WebKitPluginProcess entirely, nobody should be using this anymore.

[Santosh Mahto]

(In reply to Michael Catanzaro from comment #8)
> $0.02: I think it's time to delete WebKitPluginProcess entirely, nobody
> should be using this anymore.

Should I open new bug to remove WebKitPluginProcess and mark it as "wontFix"?
I guess this is to remove complete plugin support from webkit.

[Michael Catanzaro]

Well we need to see if GTK port maintainers agree with me before opening a bug to remove the plugin process entirely.

But this one should be WONTFIX because it's definitely not going to be available in GTK4, yes.