Bug 212121 - REGRESSION(r260978): Web Inspector: Styles: Pressing Space no longer toggles selected properties
Summary: REGRESSION(r260978): Web Inspector: Styles: Pressing Space no longer toggles ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on: 211118
Blocks:
  Show dependency treegraph
 
Reported: 2020-05-19 20:43 PDT by Nikita Vasilyev
Modified: 2020-05-20 11:01 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.93 KB, patch)
2020-05-19 20:58 PDT, Nikita Vasilyev
no flags Details | Formatted Diff | Diff
[Video] With patch applied (1.69 MB, video/quicktime)
2020-05-19 20:59 PDT, Nikita Vasilyev
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2020-05-19 20:43:01 PDT
Steps:
1. Inspect <body> on this page
2. Select several CSS properties (click and hold on the 1st body's property, drag down)
3. Press Space

Expected:
Selected properties are commented out now.

Actual:
Nothing.

Notes:
I broke it by removing `tabIndex=-1` :(
https://trac.webkit.org/changeset/260978/webkit#file3
Comment 1 Nikita Vasilyev 2020-05-19 20:58:58 PDT
Created attachment 399804 [details]
Patch
Comment 2 Nikita Vasilyev 2020-05-19 20:59:49 PDT
Created attachment 399805 [details]
[Video] With patch applied
Comment 3 Radar WebKit Bug Importer 2020-05-19 21:00:13 PDT
<rdar://problem/63429559>
Comment 4 Devin Rousso 2020-05-20 10:37:49 PDT
Comment on attachment 399804 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399804&action=review

rs=me

> Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:98
> +            let propertyView = new WI.SpreadsheetStyleProperty(this, property, {selectable: true});

and this is why I love `options = {}` 😁
Comment 5 EWS 2020-05-20 11:01:55 PDT
Committed r261933: <https://trac.webkit.org/changeset/261933>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399804 [details].