Bug 212107 - WTF::LockedPrintStream should be final
Summary: WTF::LockedPrintStream should be final
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-19 13:56 PDT by Adrian Perez
Modified: 2020-05-19 14:29 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.17 KB, patch)
2020-05-19 13:57 PDT, Adrian Perez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2020-05-19 13:56:06 PDT 
As Clang wisely advises:

../Source/WTF/wtf/LockedPrintStream.h:38:26: warning: class with destructor marked 'final' cannot be inherited from [-Wfinal-dtor-non-final-class]
    ~LockedPrintStream() final;
                         ^
../Source/WTF/wtf/LockedPrintStream.h:35:7: note: mark 'WTF::LockedPrintStream' as 'final' to silence this warning
class LockedPrintStream : public PrintStream {
      ^
1 warning generated.
Comment 1 Adrian Perez 2020-05-19 13:57:29 PDT 
Created attachment 399767 [details]
Patch
Comment 2 Darin Adler 2020-05-19 14:00:10 PDT 
Comment on attachment 399767 [details]
Patch

OK, why not.
Comment 3 EWS 2020-05-19 14:28:25 PDT 
Committed r261886: <https://trac.webkit.org/changeset/261886>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399767 [details].
Comment 4 Radar WebKit Bug Importer 2020-05-19 14:29:13 PDT 
<rdar://problem/63414754>